[jira] [Commented] (FTPSERVER-461) FtpServer implement inputClosed() or extend IoHandlerAdapter for MINA 2.0.8 or higher

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FTPSERVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218671#comment-14218671 ] 

Emmanuel Lecharny commented on FTPSERVER-461:
---------------------------------------------

Not sure that is an error.

The way it's implemented is that the {{FtpHandlerAdapter}} class does not implement the {{inputClose()}} method. As the {{FtpHandlerAdapter}} class inherits from the {{IoHandlerAdapter}} abstract class, the {{inputClose()}} method from this super class is called :

{code}
    public void inputClosed(IoSession session) throws Exception {
        session.close(true);
    }
{code}

Now, that close the FTP session.

OTOH, I don't see where the exception is coming from...

Do you have any more log ?

> FtpServer implement inputClosed() or extend IoHandlerAdapter for MINA 2.0.8 or higher
> -------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-461
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-461
>             Project: FtpServer
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.6
>            Reporter: Ulrich Kohlhase
>
> According to the Apache MINA release notes for v2.0.8:
> "There is one change that might break the build for those switching from MINA 2.0.7 to MINA 2.0.8 : the IoHandler interface now has a method called inputClosed(), so either you have to implement this method if you are directly implementing the IoHandler interface, or better, you can extends IoHandlerAdapter, which implements a placeholder for this method."
> ERROR org.apache.ftpserver.impl.DefaultFtpHandler  - Exception caught, closing session
> WARN  org.apache.ftpserver.listener.nio.FtpLoggingFilter  - EXCEPTION :
> AbstractMethodError: org.apache.ftpserver.listener.nio.FtpHandlerAdapter.inputClosed(Lorg/apache/mina/core/session/IoSession;)V
>   at org.apache.mina.core.filterchain.DefaultIoFilterChain$TailFilter.inputClosed(DefaultIoFilterChain.java:834)
>   at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextInputClosed(DefaultIoFilterChain.java:611)
>   at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(DefaultIoFilterChain.java:48)
>   at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.inputClosed(DefaultIoFilterChain.java:938)
>   at org.apache.mina.core.filterchain.IoFilterAdapter.inputClosed(IoFilterAdapter.java:137)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)