You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by du...@gmail.com on 2016/12/01 20:30:47 UTC

Re: Removing unused code

Thanks for doing this, Deron. Cleaning up the code base will make it much easier to maintain and fix issues as they arise.


-Mike

--

Mike Dusenberry
GitHub: github.com/dusenberrymw
LinkedIn: linkedin.com/in/mikedusenberry

Sent from my iPhone.


> On Nov 30, 2016, at 11:56 AM, Deron Eriksson <de...@gmail.com> wrote:
> 
> Hi,
> 
> I just submitted a few pull requests to do some minor refactoring to remove
> some unused code.
> 
> Please let me know if you believe any of this code is not actually dead
> code and should be kept, or if it should be kept with comments (such as
> 'TODO: operation needs to be implemented', etc).
> 
> [SYSTEMML-1132] Remove unused classes from project
> https://github.com/apache/incubator-systemml/pull/298
> 
> [SYSTEMML-1133] Remove unused constants from project
> https://github.com/apache/incubator-systemml/pull/299
> 
> [SYSTEMML-1134] Remove unused enums from project
> https://github.com/apache/incubator-systemml/pull/300
> 
> [SYSTEMML-1135] Remove unused enum constants from project
> https://github.com/apache/incubator-systemml/pull/301
> 
> [SYSTEMML-1136] Remove unreferenced fields and member classes
> https://github.com/apache/incubator-systemml/pull/302
> 
> Thank you,
> Deron