[jira] Commented: (PIG-1551) Improve dynamic invokers to deal with no-arg methods and array parameters

["Richard Ding (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901656#action_12901656 ] 

Richard Ding commented on PIG-1551:
-----------------------------------


In Invoker.java, there is a typo:

{code}
private static final Class<?> LONG_ARRAY_CLASS = new String[0].getClass();
{code}

also in unPrimitivize method, this code seems unnecessary:

{code}
        } else if (klass.equals(DOUBLE_ARRAY_CLASS)) {
            return DOUBLE_ARRAY_CLASS;
{code}

Otherwise the patch looks good.

> Improve dynamic invokers to deal with no-arg methods and array parameters
> -------------------------------------------------------------------------
>
>                 Key: PIG-1551
>                 URL: https://issues.apache.org/jira/browse/PIG-1551
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.8.0
>
>         Attachments: PIG-1551.patch
>
>
> PIG-1354 introduced a set of UDFs that can be used to dynamically wrap simple Java methods in a UDF, so that users don't need to create trivial wrappers if they are ok sacrificing some speed.
> This issue is to extend the set of methods that can be wrapped this way to include methods that do not take any arguments, and methods that take arrays of {int,long,float,double,string} as arguments. 
> Arrays are expected to be represented by bags in Pig. Notably, this allows users to wrap statistical functions in o.a.commons.math.stat.StatUtils . 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.