[GitHub] [hive] pvary commented on a change in pull request #2500: Hive-24467: ConditionalTask remove tasks that not selected exists thr…

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2500:
URL: https://github.com/apache/hive/pull/2500#discussion_r674195308



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java
##########
@@ -32,6 +33,8 @@
 public class ConditionalTask extends Task<ConditionalWork> implements Serializable {
 
   private static final long serialVersionUID = 1L;
+  private static final ReentrantLock RESOLVE_TASK_LOCK = new ReentrantLock();

Review comment:
       Having a JVM level global lock seems quite problematic. It could stop every query running on this HS2 instance.
   Could we find a way to restrict the scope of the lock?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org