You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikun (via GitHub)" <gi...@apache.org> on 2023/05/06 01:26:11 UTC
[GitHub] [spark-docker] Yikun opened a new pull request, #37: [SPARK-43371] Minimize duplication across layers for chmod
Yikun opened a new pull request, #37:
URL: https://github.com/apache/spark-docker/pull/37
### What changes were proposed in this pull request?
This patch minimizes duplication across layers for chmod:
- Move `chmod g+w /opt/spark/work-dir` to layer of `/opt/spark/work-dir` creation
- Move `chmod a+x /opt/decom.sh` to layer of spark extration layer.
- `chmod a+x $VERSION/$TAG/entrypoint.sh` when generate the entrypoint.sh
### Why are the changes needed?
Address DOI review comments to minimize duplication across layers for chmod
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun closed pull request #37: [SPARK-43371] Minimize duplication across layers for chmod
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun closed pull request #37: [SPARK-43371] Minimize duplication across layers for chmod
URL: https://github.com/apache/spark-docker/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #37: [SPARK-43371] Minimize duplication across layers for chmod
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #37:
URL: https://github.com/apache/spark-docker/pull/37#issuecomment-1536989331
cc @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #37: [SPARK-43371] Minimize duplication across layers for chmod
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #37:
URL: https://github.com/apache/spark-docker/pull/37#issuecomment-1537099866
@zhengruifeng Thanks, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org