[jira] [Commented] (TAP5-2477) Improvement of PerthreadManagerImpl.getPerthreadMap

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545095#comment-14545095 ] 

Jochen Kemnade commented on TAP5-2477:
--------------------------------------

Interesting find. I'm not sure if removing this code altogether is safe. But I guess a {{volatile}} or even a "regular" {{boolean}} should do the trick here. Not sure why [~hlship] decided to use an {{AtomicBoolean}}, but maybe I'm just missing something.

> Improvement of PerthreadManagerImpl.getPerthreadMap
> ---------------------------------------------------
>
>                 Key: TAP5-2477
>                 URL: https://issues.apache.org/jira/browse/TAP5-2477
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Maria Fedotova
>              Labels: patch, perfomance
>         Attachments: TAP5-2477.patch
>
>
> In this patch we removed this code
> {code}
> if (shutdown.get())
>         {
>             return CollectionFactory.newMap();
>         }
> {code}
> And it decreased time per request on 11% (~20ms).
> This patch is  already in our production.
> Thank [~mihasik] for the idea.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)