You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/24 14:31:31 UTC
Review Request 57041: DB selected is not persisted while switching
between tabs, SavedQuery tab does not show preview,
if the query is not executed before saving
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57041/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20173
https://issues.apache.org/jira/browse/AMBARI-20173
Repository: ambari
Description
-------
1.Create an worksheet and select a database called "Default".
2.Create another worksheet and select another database "Sample".
3.Switch between the worksheets and the database selection will not be persisted across the worksheets
SavedQuery tab does not show preview, if the query is not executed before saving:
If the query is not executed before saving, preview is not being shown.
Diffs
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java ef497ce
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 7b18424
contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 80a19f3
Diff: https://reviews.apache.org/r/57041/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 57041: DB selected is not persisted while switching
between tabs, SavedQuery tab does not show preview,
if the query is not executed before saving
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57041/#review166816
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 24, 2017, 2:31 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57041/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 2:31 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20173
> https://issues.apache.org/jira/browse/AMBARI-20173
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1.Create an worksheet and select a database called "Default".
> 2.Create another worksheet and select another database "Sample".
> 3.Switch between the worksheets and the database selection will not be persisted across the worksheets
> SavedQuery tab does not show preview, if the query is not executed before saving:
> If the query is not executed before saving, preview is not being shown.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java ef497ce
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 7b18424
> contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 80a19f3
>
> Diff: https://reviews.apache.org/r/57041/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57041: DB selected is not persisted while switching
between tabs, SavedQuery tab does not show preview,
if the query is not executed before saving
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57041/#review166734
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 24, 2017, 2:31 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57041/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 2:31 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20173
> https://issues.apache.org/jira/browse/AMBARI-20173
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1.Create an worksheet and select a database called "Default".
> 2.Create another worksheet and select another database "Sample".
> 3.Switch between the worksheets and the database selection will not be persisted across the worksheets
> SavedQuery tab does not show preview, if the query is not executed before saving:
> If the query is not executed before saving, preview is not being shown.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java ef497ce
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 16103b7
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js 7b18424
> contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 80a19f3
>
> Diff: https://reviews.apache.org/r/57041/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>