You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Roman Kalukiewicz (JIRA)" <ji...@apache.org> on 2008/11/18 11:19:05 UTC
[jira] Created: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Allow allInterfaces parameter for jetty endpoint
------------------------------------------------
Key: CAMEL-1097
URL: https://issues.apache.org/activemq/browse/CAMEL-1097
Project: Apache Camel
Issue Type: New Feature
Components: camel-jetty
Affects Versions: 1.5.0
Reporter: Roman Kalukiewicz
Assignee: Roman Kalukiewicz
Priority: Minor
{{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAMEL-1097) Allow allInterfaces parameter for jetty
endpoint
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kalukiewicz closed CAMEL-1097.
------------------------------------
Resolution: Won't Fix
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47476#action_47476 ]
Hadrian Zbarcea commented on CAMEL-1097:
----------------------------------------
If we were to test for something, I'd rather test for a hostname.startsWith( "0.0.0.0") than an attribute (which we may want to take out of the url before passing it to the stack anyway), and then replace the hostname value with null. But as I said, I strongly doubt that's needed at all.
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48244#action_48244 ]
Claus Ibsen commented on CAMEL-1097:
------------------------------------
+1 on Hadrians suggestion: hostname.startsWith( "0.0.0.0"
Roman what is the status of this one? Isn't this important to get into Camel 1.5.1?
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48321#action_48321 ]
Roman Kalukiewicz commented on CAMEL-1097:
------------------------------------------
After all this discussion and options presented I believe that if we want to test for {{startsWith("0.0.0.0")}} then it is better to simply close the issue and do nothing.
The reason is that someone can argue that if he/she writes {{0.0.0.0}} then he/she means it and it should be the thing passed to IP stack. In majority of situations passing 0.0.0.0 to IP stack will expose an endpoint on all interfaces via IPv4 and IPv6 (I believe). If not - the only thing we risk is that someone will have to create two endpoints for IPv4 and IPv6 separately.
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47474#action_47474 ]
Hadrian Zbarcea commented on CAMEL-1097:
----------------------------------------
I really don't see any difference between 0.0.0.0 as a hostname and anyLocalhost=true or allInterfaces=true attributes. We'd have to either check for an attribute value or the hostname value. When one reads a url, the semantics of 0.0.0.0 is pretty clear and we can put in the necessary code to deal with ipv6 (which i suspect it should be handled already anyway).
I'll give this a -1. I'll gladly change my vote if I see a compelling argument.
> This is what I really like. This way what we do is clear, and we
> explicitely mark that we want to ignore host part of the uri.
Yeah, a hostname of 0.0.0.0 would mean precisely the same thing.
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1097) Allow allInterfaces parameter for
jetty endpoint
Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47475#action_47475 ]
Roman Kalukiewicz commented on CAMEL-1097:
------------------------------------------
The point is that in case of 0.0.0.0 we don't have to check the value. We just pass it to connector and IP stack already knows what it means. With the flag we have to test and pass {{null}} instead. If there is no difference in behavior then I agree with your -1.
> Allow allInterfaces parameter for jetty endpoint
> ------------------------------------------------
>
> Key: CAMEL-1097
> URL: https://issues.apache.org/activemq/browse/CAMEL-1097
> Project: Apache Camel
> Issue Type: New Feature
> Components: camel-jetty
> Affects Versions: 1.5.0
> Reporter: Roman Kalukiewicz
> Assignee: Roman Kalukiewicz
> Priority: Minor
>
> {{allInterfaces}} parameter should allow to expose a http endpoint on all available network interfaces. It should be like passing {{null}} host to {{ServerSocket}} class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.