You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "boglesby (GitHub)" <gi...@apache.org> on 2019/01/26 00:30:45 UTC

[GitHub] [geode] boglesby commented on issue #3111: GEODE-6287: Cleaned up FilterProfile clientMap when client disconnect…

Thanks for reviewing this Bruce. Thats a good thought regarding ConcurrentModificationException.

I think its ok.

clientMap.realIDs.keySet() is a ConcurrentHashMap$KeySetView.

Collections.unmodifiableSet ends up here:
``` 
UnmodifiableCollection(Collection<? extends E> c) {
  this.c = c;
}
``` 
Then, iterator does:
``` 
private final Iterator<? extends E> i = c.iterator();
``` 
So, iterating the UnmodifiableSet is iterating the ConcurrentHashMap$KeySetView's iterator which should be thread-safe.


[ Full content available at: https://github.com/apache/geode/pull/3111 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org