[Proposal] Change *attempts_timeout to milliseconds from seconds

["Zelkowitz, Evan" <Ev...@comcast.com>]

?Currently all the attempts_timeout values are in seconds. We have seen some issues where we believe being able to have a finer granularity over this may help alleviate some problems.  Also for live streaming video in 2 second fragments a 1 second timeout does not provide as much control. So proposing that we change these to milliseconds.


We briefly discussed on IRC some alternatives such as using floats, but that could introduce precision issues, as well as adding values such as 'ms' 's' etc. The latter might be nice but that is a large change since there currently is no units parsing for values in records.config so it might be nice to have in the future but thats a much larger scope of work.

Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

[Alan Carroll <so...@oath.com.INVALID>]

Not directly, but I do think that when this gets converted to YAML we make
*all* durations seconds by default, with a suffix or metric option to
specify other time units. For a stop gap, Walt might be right and we could
just add a parallel configuration variable with "_ms" at the end to specify
this value in milliseconds on the presumption that will get cleaned up
during the conversion.

On Thu, Aug 16, 2018 at 7:35 PM Zelkowitz, Evan <Ev...@comcast.com>
wrote:

> Anyone have any other thoughts? As of now Im contemplating doing the
> change to _ms internally, since at least that might help to mitigate
> records settings confusion across a CDN in the short term if we need this
> for our own purposes. I do like the idea of having types when it's time to
> yamilfy everything but didnt know if people would mind a short term change
> in names before then (like for 8.0.x) or if we hold off doing this in the
> community until yaml time
> ________________________________________
> From: Walt Karas <wk...@oath.com.INVALID>
> Sent: Wednesday, August 15, 2018 12:45 PM
> To: dev@trafficserver.apache.org
> Subject: [EXTERNAL] Re: [Proposal] Change *attempts_timeout to
> milliseconds from seconds
>
> Or jump off.
>
>
> On Wed, Aug 15, 2018 at 1:27 PM, Alan Carroll
> <so...@oath.com.invalid> wrote:
> > I thought about that, but I think that's not the best approach because we
> > want to make it more general, so it can have seconds or milliseconds.
> OTOH
> > maybe that will have to wait until we YAMLize it. If we could do
> anything,
> > I'd add the type "TIME" vs. "INT" and "STRING" and have that be seconds
> > unless modified with a suffix like "ms" or "minutes", etc. I may take a
> > look at how hard that would be. Unless Walt wants to jump in?
> >
> > On Wed, Aug 15, 2018 at 1:22 PM Walt Karas <wk...@oath.com.invalid>
> wrote:
> >
> >> Would it perhaps be a good idea to add a _ms suffix to the config
> >> variable names of timeouts that are not seconds?
> >>
> >> On Wed, Aug 15, 2018 at 12:15 PM, Zelkowitz, Evan
> >> <Ev...@comcast.com> wrote:
> >> > ?Currently all the attempts_timeout values are in seconds. We have
> seen
> >> some issues where we believe being able to have a finer granularity over
> >> this may help alleviate some problems.  Also for live streaming video
> in 2
> >> second fragments a 1 second timeout does not provide as much control. So
> >> proposing that we change these to milliseconds.
> >> >
> >> >
> >> > We briefly discussed on IRC some alternatives such as using floats,
> but
> >> that could introduce precision issues, as well as adding values such as
> >> 'ms' 's' etc. The latter might be nice but that is a large change since
> >> there currently is no units parsing for values in records.config so it
> >> might be nice to have in the future but thats a much larger scope of
> work.
> >>
> >
> >
> > --
> > *Beware the fisherman who's casting out his line in to a dried up
> riverbed.*
> > *Oh don't try to tell him 'cause he won't believe. Throw some bread to
> the
> > ducks instead.*
> > *It's easier that way. *- Genesis : Duke : VI 25-28
>


-- 
*Beware the fisherman who's casting out his line in to a dried up riverbed.*
*Oh don't try to tell him 'cause he won't believe. Throw some bread to the
ducks instead.*
*It's easier that way. *- Genesis : Duke : VI 25-28

Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

["Zelkowitz, Evan" <Ev...@comcast.com>]

Anyone have any other thoughts? As of now Im contemplating doing the change to _ms internally, since at least that might help to mitigate records settings confusion across a CDN in the short term if we need this for our own purposes. I do like the idea of having types when it's time to yamilfy everything but didnt know if people would mind a short term change in names before then (like for 8.0.x) or if we hold off doing this in the community until yaml time
________________________________________
From: Walt Karas <wk...@oath.com.INVALID>
Sent: Wednesday, August 15, 2018 12:45 PM
To: dev@trafficserver.apache.org
Subject: [EXTERNAL] Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

Or jump off.


On Wed, Aug 15, 2018 at 1:27 PM, Alan Carroll
<so...@oath.com.invalid> wrote:
> I thought about that, but I think that's not the best approach because we
> want to make it more general, so it can have seconds or milliseconds. OTOH
> maybe that will have to wait until we YAMLize it. If we could do anything,
> I'd add the type "TIME" vs. "INT" and "STRING" and have that be seconds
> unless modified with a suffix like "ms" or "minutes", etc. I may take a
> look at how hard that would be. Unless Walt wants to jump in?
>
> On Wed, Aug 15, 2018 at 1:22 PM Walt Karas <wk...@oath.com.invalid> wrote:
>
>> Would it perhaps be a good idea to add a _ms suffix to the config
>> variable names of timeouts that are not seconds?
>>
>> On Wed, Aug 15, 2018 at 12:15 PM, Zelkowitz, Evan
>> <Ev...@comcast.com> wrote:
>> > ?Currently all the attempts_timeout values are in seconds. We have seen
>> some issues where we believe being able to have a finer granularity over
>> this may help alleviate some problems.  Also for live streaming video in 2
>> second fragments a 1 second timeout does not provide as much control. So
>> proposing that we change these to milliseconds.
>> >
>> >
>> > We briefly discussed on IRC some alternatives such as using floats, but
>> that could introduce precision issues, as well as adding values such as
>> 'ms' 's' etc. The latter might be nice but that is a large change since
>> there currently is no units parsing for values in records.config so it
>> might be nice to have in the future but thats a much larger scope of work.
>>
>
>
> --
> *Beware the fisherman who's casting out his line in to a dried up riverbed.*
> *Oh don't try to tell him 'cause he won't believe. Throw some bread to the
> ducks instead.*
> *It's easier that way. *- Genesis : Duke : VI 25-28

Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

[Walt Karas <wk...@oath.com.INVALID>]

Or jump off.


On Wed, Aug 15, 2018 at 1:27 PM, Alan Carroll
<so...@oath.com.invalid> wrote:
> I thought about that, but I think that's not the best approach because we
> want to make it more general, so it can have seconds or milliseconds. OTOH
> maybe that will have to wait until we YAMLize it. If we could do anything,
> I'd add the type "TIME" vs. "INT" and "STRING" and have that be seconds
> unless modified with a suffix like "ms" or "minutes", etc. I may take a
> look at how hard that would be. Unless Walt wants to jump in?
>
> On Wed, Aug 15, 2018 at 1:22 PM Walt Karas <wk...@oath.com.invalid> wrote:
>
>> Would it perhaps be a good idea to add a _ms suffix to the config
>> variable names of timeouts that are not seconds?
>>
>> On Wed, Aug 15, 2018 at 12:15 PM, Zelkowitz, Evan
>> <Ev...@comcast.com> wrote:
>> > ?Currently all the attempts_timeout values are in seconds. We have seen
>> some issues where we believe being able to have a finer granularity over
>> this may help alleviate some problems.  Also for live streaming video in 2
>> second fragments a 1 second timeout does not provide as much control. So
>> proposing that we change these to milliseconds.
>> >
>> >
>> > We briefly discussed on IRC some alternatives such as using floats, but
>> that could introduce precision issues, as well as adding values such as
>> 'ms' 's' etc. The latter might be nice but that is a large change since
>> there currently is no units parsing for values in records.config so it
>> might be nice to have in the future but thats a much larger scope of work.
>>
>
>
> --
> *Beware the fisherman who's casting out his line in to a dried up riverbed.*
> *Oh don't try to tell him 'cause he won't believe. Throw some bread to the
> ducks instead.*
> *It's easier that way. *- Genesis : Duke : VI 25-28

Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

[Alan Carroll <so...@oath.com.INVALID>]

I thought about that, but I think that's not the best approach because we
want to make it more general, so it can have seconds or milliseconds. OTOH
maybe that will have to wait until we YAMLize it. If we could do anything,
I'd add the type "TIME" vs. "INT" and "STRING" and have that be seconds
unless modified with a suffix like "ms" or "minutes", etc. I may take a
look at how hard that would be. Unless Walt wants to jump in?

On Wed, Aug 15, 2018 at 1:22 PM Walt Karas <wk...@oath.com.invalid> wrote:

> Would it perhaps be a good idea to add a _ms suffix to the config
> variable names of timeouts that are not seconds?
>
> On Wed, Aug 15, 2018 at 12:15 PM, Zelkowitz, Evan
> <Ev...@comcast.com> wrote:
> > ?Currently all the attempts_timeout values are in seconds. We have seen
> some issues where we believe being able to have a finer granularity over
> this may help alleviate some problems.  Also for live streaming video in 2
> second fragments a 1 second timeout does not provide as much control. So
> proposing that we change these to milliseconds.
> >
> >
> > We briefly discussed on IRC some alternatives such as using floats, but
> that could introduce precision issues, as well as adding values such as
> 'ms' 's' etc. The latter might be nice but that is a large change since
> there currently is no units parsing for values in records.config so it
> might be nice to have in the future but thats a much larger scope of work.
>


-- 
*Beware the fisherman who's casting out his line in to a dried up riverbed.*
*Oh don't try to tell him 'cause he won't believe. Throw some bread to the
ducks instead.*
*It's easier that way. *- Genesis : Duke : VI 25-28

Re: [Proposal] Change *attempts_timeout to milliseconds from seconds

[Walt Karas <wk...@oath.com.INVALID>]

Would it perhaps be a good idea to add a _ms suffix to the config
variable names of timeouts that are not seconds?

On Wed, Aug 15, 2018 at 12:15 PM, Zelkowitz, Evan
<Ev...@comcast.com> wrote:
> ?Currently all the attempts_timeout values are in seconds. We have seen some issues where we believe being able to have a finer granularity over this may help alleviate some problems.  Also for live streaming video in 2 second fragments a 1 second timeout does not provide as much control. So proposing that we change these to milliseconds.
>
>
> We briefly discussed on IRC some alternatives such as using floats, but that could introduce precision issues, as well as adding values such as 'ms' 's' etc. The latter might be nice but that is a large change since there currently is no units parsing for values in records.config so it might be nice to have in the future but thats a much larger scope of work.