[GitHub] [incubator-superset] ali-bahjati commented on a change in pull request #7827: Fix docker configurations and docker installation guide.

[GitBox <gi...@apache.org>]

ali-bahjati commented on a change in pull request #7827: Fix docker configurations and docker installation guide.
URL: https://github.com/apache/incubator-superset/pull/7827#discussion_r302165277
 
 

 ##########
 File path: contrib/docker/docker-compose.yml
 ##########
 @@ -20,7 +20,7 @@ services:
     image: redis:3.2
     restart: unless-stopped
     ports:
-      - 6379:6379
+      - "127.0.0.1:6379:6379"
 
 Review comment:
   This mean that you only open the port on the host loop interface. Otherwise it will be open in main network interface and overrides iptable blocking rules.
   I added this because first of all we don't need to expose the port at all. And second if we need it for debug it's better to be on loop interface to maintain security in the service. (Take a look at [this](https://fralef.me/docker-and-iptables.html) article)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org