You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/03/27 13:29:43 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #273: upgrade to jackson 2.14.2
pjfanning opened a new pull request, #273:
URL: https://github.com/apache/incubator-pekko/pull/273
https://github.com/apache/incubator-pekko/issues/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #273: upgrade to jackson 2.14.2
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485185226
@mdedetrich any idea how to get the Scala 3 build to ignore deprecation issues? https://github.com/apache/incubator-pekko/actions/runs/4532777359/jobs/7984657231?pr=273 is failing, seems to be because it won't allow deprecated code in the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485191193
@pjfanning
> @mdedetrich any idea how to get the Scala 3 build to ignore deprecation issues? https://github.com/apache/incubator-pekko/actions/runs/4532777359/jobs/7984657231?pr=273 is failing, seems to be because it won't allow deprecated code in the build
How about adding `@nowarn(cat="msg=deprecated")` on the function where its being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #273: upgrade to jackson 2.14.2
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1497329805
@mdedetrich @jrudolph are there further changes needed here or is it safe to proceed with a merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #273: upgrade to jackson 2.14.2
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #273: upgrade to jackson 2.14.2
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485324030
> @pjfanning Okay so for the new errors in https://github.com/apache/incubator-pekko/actions/runs/4533274521/jobs/7985858691?pr=273 you probably need to port some of the fixes from #270, specifically the `@unchecked` ones
Thanks @mdedetrich - it looks like I needed all your code changes from your Scala 3.3 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485254545
@pjfanning Okay so for the new errors in https://github.com/apache/incubator-pekko/actions/runs/4533274521/jobs/7985858691?pr=273 you probably need to port some of the fixes from https://github.com/apache/incubator-pekko/pull/270, specifically the `@unchecked` ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #273: upgrade to jackson 2.14.2
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#discussion_r1157006693
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -134,7 +136,7 @@ object PekkoDisciplinePlugin extends AutoPlugin {
case Some((2, 12)) =>
disciplineScalacOptions
case _ =>
- Nil
+ Seq("-Wconf:cat=deprecation:s")
Review Comment:
Does that mean we disable all deprecation warnings for Scala 3 for all submodules. Is that really what we want?
You can also match by other factors, so maybe we can restrict the silencing to Jackson in particular?
##########
actor-typed-tests/src/test/scala/docs/org/apache/pekko/typed/InteractionPatternsSpec.scala:
##########
@@ -33,6 +33,14 @@ import pekko.actor.typed.scaladsl.TimerScheduler
import pekko.pattern.StatusReply
import org.scalatest.wordspec.AnyWordSpecLike
+// #per-session-child
+// dummy data types just for this sample
+case class Keys()
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485195762
Alternately you can just copy https://github.com/apache/incubator-pekko/pull/270/files#diff-676691b2e85cad6026adb107942b7c9325394e20e015b131fdcebd3b2b7794b0R137 from my Scala 3.3 PR, that will just globally disable any deprecation warnings in the Scala3 build (which we will probably have to do in the future anyways).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1495714369
> I don't quite see how the general silencing and the @nowarn and @unchecked annotation changes play together here. Can we find a way to silence exactly the deprecation warnings we are concerned about and only in that submodule?
@jrudolph So the changes here were copied from my work in Scala 3.3 (see https://github.com/apache/incubator-pekko/pull/270) because it turns out all of the Scala 3 specific changes done in the Scala 3.3 PR due to Scala 3 changes was actually add in Scala 3.2 (which this PR is updating to).
With the deprecation warnings, there was a lot of places that Scala 3.2/3.3 was warning about deprecation so at least in my Scala 3.3 PR I made the decision to add the flag in order to reduce noise. While it was possible to use the `@nowarn` flag to silence the deprecation, these deprecation warnings was being generated in code that is being shared between Scala 2 and Scala 3 which means that if we were to use the `@nowarn` flag we would have to do changes to the Scala 2 compiler flags in order to not complain if no warnings were silenced (latest versions of Scala 2.12/2.13 will generate a warning if you use a `@nowarn` annotation that doesn't actually suppress anything, and iirc these deprecations warnings are Scala 3.2/3.3 specific and don't occur in Scala 2.12/2.13)
Regarding `@unchecked`, this seems to be due to an improvement that landed in Scala 3.2 which improves the exhaustiveness checking for pattern matching cases. Originally in my Scala 3.3 PR I tried to find a flag which covers only these new cases that require `@unchecked` so it can be silenced but it appears that the change in Scala 3.2 is extending an already existing case of exhaustiveness checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #273: upgrade to jackson 2.14.2
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1497442060
Thanks for the explanation, @mdedetrich. The whole linting business here is quite a mess anyway, so it's ok for me to go ahead. Maybe create a ticket to revisit linting rules for Scala 3 (or overall...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1485233681
@pjfanning For the latest error you probably need to add `serialization-jackson` into `PekkoDisciplinePlugin.nonFatalJavaWarningsFor` (along with a comment explaining why). The same error is also occurring in Scala 2.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#discussion_r1157028355
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -134,7 +136,7 @@ object PekkoDisciplinePlugin extends AutoPlugin {
case Some((2, 12)) =>
disciplineScalacOptions
case _ =>
- Nil
+ Seq("-Wconf:cat=deprecation:s")
Review Comment:
To provide some context, this flag is needed for Scala 3.2.x in general, not Jackson specifically. It appears there was an issue in Scala 3.1.x where it wasn't reporting deprecations as it should and this was fixed in Scala 3.2. I also had to the do the same fix in the PR I created that **only** updates to Scala 3.3 (with no other changes), see https://github.com/apache/incubator-pekko/pull/270/files#diff-676691b2e85cad6026adb107942b7c9325394e20e015b131fdcebd3b2b7794b0R137.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #273: upgrade to jackson 2.14.2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #273:
URL: https://github.com/apache/incubator-pekko/pull/273#issuecomment-1497483654
LGTM as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org