You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2020/10/19 10:03:50 UTC

Review Request 72971: RANGER-3029 : Ranger - Upgrade handlebars 1.3.0 to 4.6.0.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72971/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-3029
    https://issues.apache.org/jira/browse/RANGER-3029


Repository: ranger


Description
-------

Good to update handlebars.js for batter functionality and solved exiting bug.


Diffs
-----

  security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/Handlebars.js 2f5f321 
  security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js a40eb98 
  security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/i18nprecompile.js 22b4133 
  security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html 7b20877 
  security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834 
  security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 14b3757 
  security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html 5a22597 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 456e194 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html be8881c 
  security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html f06c007 
  security-admin/src/main/webapp/templates/reports/UserUpdateOperationDiff_tmpl.html b22cea3 


Diff: https://reviews.apache.org/r/72971/diff/1/


Testing
-------

Tested Old/New UI with
Service CRUD
Policy CRUD
User/group and role CRUD
Zone CRUD
All audit logs detais views


Thanks,

Nitin Galave


Re: Review Request 72971: RANGER-3029 : Ranger - Upgrade handlebars 1.3.0 to 4.6.0.

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72971/#review222068
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Oct. 19, 2020, 10:03 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72971/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2020, 10:03 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3029
>     https://issues.apache.org/jira/browse/RANGER-3029
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good to update handlebars.js for batter functionality and solved exiting bug.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/Handlebars.js 2f5f321 
>   security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js a40eb98 
>   security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/i18nprecompile.js 22b4133 
>   security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html 7b20877 
>   security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 14b3757 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html 5a22597 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 456e194 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html be8881c 
>   security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html f06c007 
>   security-admin/src/main/webapp/templates/reports/UserUpdateOperationDiff_tmpl.html b22cea3 
> 
> 
> Diff: https://reviews.apache.org/r/72971/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Old/New UI with
> Service CRUD
> Policy CRUD
> User/group and role CRUD
> Zone CRUD
> All audit logs detais views
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>