You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/11/16 13:01:28 UTC
[GitHub] carbondata pull request #1509: [CARBONDATA-1739] Clean up store path interfa...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1509
[CARBONDATA-1739] Clean up store path interface
There are many getStorePath API, this PR unified it in one place: `CarbonProperties.getStorePath`
It can be used in driver side
- [X] Any interfaces changed?
Yes
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
No new testcase is added
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
MR2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata tableinfo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1509
----
commit 09ff30688fe84c199fb86b92b9547c859e05a75c
Author: Jacky Li <ja...@qq.com>
Date: 2017-11-16T09:27:21Z
add s3 in filefactory
commit 8d31b0974071bb7cd8ad72aa58990b9f2621b8a1
Author: Jacky Li <ja...@qq.com>
Date: 2017-11-16T11:41:19Z
remove unnecessary path
commit 5a7008e0691daff9bad3c8bf707d0592500a1f24
Author: Jacky Li <ja...@qq.com>
Date: 2017-11-16T12:56:55Z
clean CarbonEnv
----
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1509
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1208/
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1509
I found the commit 'add s3 in filefactory' appears in many prs.
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1509
LGTM
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1509
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1199/
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1509
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1183/
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1509
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1198/
---
[GitHub] carbondata pull request #1509: [CARBONDATA-1739] Clean up store path interfa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1509
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1509
@zzcclp because I implement those PR one by one, so it is on top of #1504
---
[GitHub] carbondata issue #1509: [CARBONDATA-1739] Clean up store path interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1509
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1201/
---