You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by mzapletal <gi...@git.apache.org> on 2015/09/25 16:13:51 UTC
[GitHub] camel pull request: ADDED unit and integration test for RedisStrin...
GitHub user mzapletal opened a pull request:
https://github.com/apache/camel/pull/621
ADDED unit and integration test for RedisStringIdempotentRepository
The unit test is pretty much copied from `RedisIdempotentRepository` since add/remove logic is almost the same and expiry cannot be tested based on the unit test.
Hence, I've added an integration test as well, which revealed an important issue: the scan/delete keys logic in the `clear`method does not work using ``Jedis`` and having the ``RedisTemplate`` configured with the standard serializer as key serializer. It, however, works with ``lettuce`` and the standard serializer. It works for both clients if the ``RedisTemplate`` is configured with the ``StringRedisSerializer`` as key serializer. In principle, I would recommend to always work with the ``StringRedisSerializer`` when using Strings as keys as for example described in http://stackoverflow.com/questions/13215024/weird-redis-key-with-spring-data-jedis
I am not sure, however, if we can/should enforce the ``StringRedisSerializer`` in the configuration, since the ``RedisTemplate`` could be generally reused across the application (where the usage of ``StringRedisSerializer`` might not be desired).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mzapletal/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/621.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #621
----
commit de9acaca6997ddcb5b62c0de2e5de8b3229b6e1e
Author: Marco Zapletal <ma...@edistream.com>
Date: 2015-09-25T13:56:52Z
ADDED unit and integration test for RedisStringIdempotentRepository
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request: ADDED unit and integration test for RedisStrin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/camel/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---