You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/02/03 17:47:59 UTC

[jira] Created: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Add properties to QueueDeclare to enable flow-to-disk extensions
----------------------------------------------------------------

                 Key: QPID-1639
                 URL: https://issues.apache.org/jira/browse/QPID-1639
             Project: Qpid
          Issue Type: Sub-task
            Reporter: Martin Ritchie




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679642#action_12679642 ] 

Martin Ritchie commented on QPID-1639:
--------------------------------------

Sorry Rajith, missed your comment here. I think any changes to URL are independent of the change to include the processing of the field table on the QueueDeclare like the C++ broker. The binding does not have any impact on the declaration of the queue.

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1639:
------------------------------------

    Assignee: Rob Godfrey  (was: Martin Ritchie)

Hi, Rob can you review this change for me please.
A new QueueCreateTest has been added to test the properties are correctly created.

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Rob Godfrey
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679257#action_12679257 ] 

Rajith Attapattu commented on QPID-1639:
----------------------------------------

We should take this opportunity to do a more wider overhaul of our binding URL structure.
There were several discussion threads on this subject and here are the requirement I believe we wanted to satisfy.

1. Declare a queue with declare arguments (such as flow-to-disk extensions)
2. Bind a queue to an exchange using binding arguments
3. Have more than one such binding for a given queue. 
(That is the same queue could be bound to a given exchange with multiple binding keys or to bind using multiple exchagne/binding key pairs
Currently we support the former but not the latter).

One option suggested by Martin was to have a declare definition and separate binding definitions.
We could obviously support the legacy definition where both are done in one line.

So perhaps we can change the title and scope of this JIRA or create another JIRA for the above and make this a dependent of it.

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1639:
------------------------------------

    Assignee: Martin Ritchie

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1639:
---------------------------------

           Component/s: Java Broker
         Fix Version/s: M5
           Description: Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.
     Affects Version/s: M4
    Remaining Estimate: 4h
     Original Estimate: 4h

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1639:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-1639) Add properties to QueueDeclare to enable flow-to-disk extensions

Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679664#action_12679664 ] 

Rajith Attapattu commented on QPID-1639:
----------------------------------------

Martin, sorry I misunderstood the intent of the JIRA.
I believe what you did was to work out the queueDeclare method.
In that case I agree it is independent of the binding URL

So if a java application wants to use this feature it will have to use the AMQQueue class directly right?



> Add properties to QueueDeclare to enable flow-to-disk extensions
> ----------------------------------------------------------------
>
>                 Key: QPID-1639
>                 URL: https://issues.apache.org/jira/browse/QPID-1639
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Assignee: Rob Godfrey
>             Fix For: M5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Allow properties from QPID-1633 to be set via the AMQP QueueDelcare method in much the same way that the C++ broker allows. Ideally reusing property names where possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org