You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2017/01/20 17:36:39 UTC
[GitHub] brooklyn-server pull request #532: Add missing @Override annotations and oth...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/532
Add missing @Override annotations and other cleanup
* add missing `@Override` annotations
* add missing `@Deprecated` annotations (usually just javadoc `@override` exists)
* remove unused imports
* remove unnecessary casts
Look at each commit individually.
Similar PRs created for the other brooklyn sub-projects.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #532
----
commit 0d2d5d6a7a3568c4ed4c4aee4d07dd5982802d9e
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T10:45:34Z
Add missing @Override annotations
commit e61caea44a535ea1aeda0ea8633b3a0d7c38c8ec
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:00:40Z
Add missing @Override annotation to method signatures overriding interface methods
commit dfa8aa2926fbecc884ffa75cb5c820c6174199c4
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:24:50Z
Add missing @Deprecated annotations
commit 070d4ef568528423f78079370b760df3e7fa6990
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:27:10Z
Remove unused imports
commit c0f11d0748698d8368a7a0619f53ad6806ac7b5b
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:58:08Z
Remove unnecessary casts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #532: Add missing @Override annotations and other clea...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/532
Looks good to me. Anything more to come @neykov?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #532: Add missing @Override annotations and other clea...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/532
Nope, all done :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #532: Add missing @Override annotations and oth...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---