You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "wy-ei (via GitHub)" <gi...@apache.org> on 2023/05/27 06:38:33 UTC

[GitHub] [incubator-kvrocks] wy-ei commented on pull request #1476: fix bad case in the format of monitor response and improve performance

wy-ei commented on PR #1476:
URL: https://github.com/apache/incubator-kvrocks/pull/1476#issuecomment-1565235348

   @PragmaTwice  If redis use bulk string as the monitor response format, this issue does't exists any more. But the simple string is used and the issue is exists. This change is a workaround and it has fix the bad case and make it compatible with redis.
   
   It's easy to change the format as bulk string or array, but client SDK may not work.
   
   For example, in redis-py, unescaping is applyed on monitor response:
   
   https://github.com/redis/redis-py/blob/2d9b5ac6fe03fdc572b8ca47f7134082bae2a5e2/redis/client.py#L1337
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org