You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/08 06:43:18 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #14098: [test] Replace PowerMockito#mockStatic usages with mockito-inline

eolivelli commented on a change in pull request #14098:
URL: https://github.com/apache/pulsar/pull/14098#discussion_r801307900



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
##########
@@ -127,6 +127,25 @@
 @Slf4j
 public class NarClassLoader extends URLClassLoader {
 
+    public static class Factory {

Review comment:
       Can we add a comment that explains why we need this class?
   It is a pattern that sounds a little unusual to me.
   
   What about using the Builder pattern?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org