[GitHub] [incubator-echarts] pissang edited a comment on pull request #13390: [5.0] [Feature] sunburst series supports cornerRadius

[GitBox <gi...@apache.org>]

pissang edited a comment on pull request #13390:
URL: https://github.com/apache/incubator-echarts/pull/13390#issuecomment-705978269


   > Though I would like to name it after borderRadius to keep naming uniform, I think cornerRadius is more suitable for the sector shape and is more semantic. Moreover, I found most of chart libraries call it cornerRadius, such as amcharts, d3.
   However, on the contrary, borderRadius is more corresponding with the naming of border in CSS and many options in ECharts are currently using this kind of naming.
   
   Almost the same concern. But I think a uniform naming is slightly better after struggling with my mind. 
   
   @plainheart Are you planning to do these two changes? I'm fine to do this work today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org