You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/05 01:31:16 UTC
Re: Review Request 18386: Option reference cleanup in mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/
-----------------------------------------------------------
(Updated March 4, 2014, 4:31 p.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
Option reference cleanup in mesos.
Bugs: MESOS-1008
https://issues.apache.org/jira/browse/MESOS-1008
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
Diff: https://reviews.apache.org/r/18386/diff/
Testing
-------
make check
'grep' for cases where Options are reassigned after references are taken.
Thanks,
Dominic Hamon
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36511
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18386]
All tests passed.
- Mesos ReviewBot
On March 5, 2014, 12:31 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 12:31 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36842
-----------------------------------------------------------
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/18386/#comment68031>
Kill this?
src/slave/status_update_manager.cpp
<https://reviews.apache.org/r/18386/#comment68032>
Kill this?
- Ben Mahler
On March 10, 2014, 8:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 8:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36726
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18386]
All tests passed.
- Mesos ReviewBot
On March 10, 2014, 8:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 8:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review37162
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 11, 2014, 10:20 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:20 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36902
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18386]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 10:20 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:20 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/
-----------------------------------------------------------
(Updated March 11, 2014, 3:20 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1008
https://issues.apache.org/jira/browse/MESOS-1008
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
Diff: https://reviews.apache.org/r/18386/diff/
Testing
-------
make check
'grep' for cases where Options are reassigned after references are taken.
Thanks,
Dominic Hamon
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/
-----------------------------------------------------------
(Updated March 10, 2014, 1:35 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1008
https://issues.apache.org/jira/browse/MESOS-1008
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
Diff: https://reviews.apache.org/r/18386/diff/
Testing
-------
make check
'grep' for cases where Options are reassigned after references are taken.
Thanks,
Dominic Hamon
Re: Review Request 18386: Option reference cleanup in mesos.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18386/#review36691
-----------------------------------------------------------
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/18386/#comment67747>
ditto here
src/slave/status_update_manager.cpp
<https://reviews.apache.org/r/18386/#comment67746>
Why don't we do the same update here as we did in slave.cpp?
That is, we can pull out the option, CHECK_SOME and just use run.get() rather than needing the temporary '_run' variable.
- Ben Mahler
On March 5, 2014, 12:31 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18386/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 12:31 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db
> src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
> src/slave/status_update_manager.cpp 9db53e8b2a6440b7eebe3bc61912b170bde7a473
>
> Diff: https://reviews.apache.org/r/18386/diff/
>
>
> Testing
> -------
>
> make check
>
> 'grep' for cases where Options are reassigned after references are taken.
>
>
> Thanks,
>
> Dominic Hamon
>
>