You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jonathan Anstey (JIRA)" <ji...@apache.org> on 2012/10/17 19:50:03 UTC
[jira] [Created] (KARAF-1938) Lock logic should wait for start
level change to occur
Jonathan Anstey created KARAF-1938:
--------------------------------------
Summary: Lock logic should wait for start level change to occur
Key: KARAF-1938
URL: https://issues.apache.org/jira/browse/KARAF-1938
Project: Karaf
Issue Type: Bug
Affects Versions: 2.2.9
Reporter: Jonathan Anstey
Consider the case where we have a master and slave Karaf instance:
1. Master has acquired lock
... time passes...
2. Network problem happens
3. Master loses lock (due to the network problem) and reduces start level accordingly
4. Before start level reduction is complete master manages to grab the lock
6. Start level is set back to normal
Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved KARAF-1938.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.3.1
2.2.10
Apply patch on behalf of Jonathan Anstey with thanks
http://svn.apache.org/viewvc?rev=1400794&view=rev for 2.2.x branch
http://svn.apache.org/viewvc?rev=1401944&view=rev for 2.3.x branch
http://svn.apache.org/viewvc?rev=1403940&view=rev for trunk
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Fix For: 2.2.10, 2.3.1, 3.0.0
>
> Attachments: KARAF-1938.2.3.x.patch, KARAF-1938.patch, KARAF-1938.trunk.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481260#comment-13481260 ]
Freeman Fang commented on KARAF-1938:
-------------------------------------
apply patch on behalf of Jonathan Anstey with thanks.
http://svn.apache.org/viewvc?rev=1400794&view=rev for 2.2.x branch
@Jon
Do you mind also provide patch against 2.3.x branch and trunk?
Thanks
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480025#comment-13480025 ]
Jonathan Anstey commented on KARAF-1938:
----------------------------------------
Oh, and if it wasn't obvious, this patch needs to be applied in the main dir (http://svn.apache.org/repos/asf/karaf/branches/karaf-2.2.x/main/).
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned KARAF-1938:
-----------------------------------
Assignee: Freeman Fang
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-1938 started by Freeman Fang.
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Anstey updated KARAF-1938:
-----------------------------------
Attachment: KARAF-1938.trunk.patch
KARAF-1938.2.3.x.patch
Here are the patches to fix trunk and the 2.3.x branch.
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Attachments: KARAF-1938.2.3.x.patch, KARAF-1938.patch, KARAF-1938.trunk.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481352#comment-13481352 ]
Jonathan Anstey commented on KARAF-1938:
----------------------------------------
Thanks Freeman. Yeah, I'll find some time soon to do up trunk & 2.3 patches.
Cheers,
Jon
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Assignee: Freeman Fang
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1938) Lock logic should wait for start
level change to occur
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Anstey updated KARAF-1938:
-----------------------------------
Attachment: KARAF-1938.patch
Patch to fix issue for 2.2.x. I can do up an additional patch for trunk, etc if this change is OK.
> Lock logic should wait for start level change to occur
> ------------------------------------------------------
>
> Key: KARAF-1938
> URL: https://issues.apache.org/jira/browse/KARAF-1938
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.9
> Reporter: Jonathan Anstey
> Attachments: KARAF-1938.patch
>
>
> Consider the case where we have a master and slave Karaf instance:
> 1. Master has acquired lock
> ... time passes...
> 2. Network problem happens
> 3. Master loses lock (due to the network problem) and reduces start level accordingly
> 4. Before start level reduction is complete master manages to grab the lock
> 6. Start level is set back to normal
> Seems that flipping the start level around before the container has time to complete is not safe. Proposed solution is to just pause the locking loop until the start level is actually complete before trying to regain the lock. This will prevent flipping of the start level too quickly. Patch coming soon
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira