[GitHub] [hive] deniskuzZ commented on a diff in pull request #4447: HIVE-27460: HiveMetastoreClient should not wrap TTransportException in MetaException

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #4447:
URL: https://github.com/apache/hive/pull/4447#discussion_r1243595278


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -936,6 +921,9 @@ private TTransport createAuthBinaryTransport(URI store, TTransport underlyingTra
       } catch (IOException | TTransportException sasle) {
         // IOException covers SaslException
         LOG.error("Could not create client transport", sasle);
+        if (sasle instanceof TTransportException) {

Review Comment:
   why is this hack? could we handle IOException & TTransportException separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org