You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/03 15:50:57 UTC

[GitHub] lprashant-94 commented on a change in pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty

lprashant-94 commented on a change in pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty
URL: https://github.com/apache/incubator-superset/pull/4728#discussion_r178873137
 
 

 ##########
 File path: superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
 ##########
 @@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) {
       onClick={() => props.runQuery(true)}
       key="run-async-btn"
       tooltip={t('Run query asynchronously')}
+      disabled={!props.sql.trim()}
 
 Review comment:
   I have made changes, please review :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services