[jira] Commented: (TUSCANY-2953) Fix sca.tld in branches-1.x

["ant elder (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695004#action_12695004 ] 

ant elder commented on TUSCANY-2953:
------------------------------------

The current split is historical, we had the JSP taglib as the first thing from the JEE spec Tuscany supported (before then we didn't have a vary good way of using SCA from JSP or webclients) so it was done in host-webapp as implementation-web-runtime didn't exist. If it was moved out of host-webapp and al put in the implementation-webapp modules that would break existing users who aren't including the implementation-webapp modules. Maybe that doesn't matter and we could doc the changed dependency requirement in a release notes file. This has been tidied up a lot in 2.x.


 

> Fix sca.tld in branches-1.x
> ---------------------------
>
>                 Key: TUSCANY-2953
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2953
>             Project: Tuscany
>          Issue Type: Bug
>            Reporter: Kevan Miller
>         Attachments: sca.patch
>
>
> I'm not sure I understand the motivations for the location of sca.tld (in implementation-web-runtime) and JSP implementation (in tuscany-host-webapp).
> There are currently two sca.tld's in branches/1.x and am reasonably sure that there should only be one.
> I'm absolutely sure that the sca.tld in branches/sca-java-1.x/modules/implementation-web-runtime/src/main/resources/META-INF/sca.tld is incorrect, in that it refers to org.apache.tuscany.sca.implementation.web.taglib.ReferenceTag and org.apache.tuscany.sca.implementation.web.taglib.ReferenceTEI, which no longer exist.
> I'm guessing that branches/sca-java-1.x/modules/host-webapp/src/main/resources/META-INF/sca.tld should be removed and branches/sca-java-1.x/modules/implementation-web-runtime/src/main/resources/META-INF/sca.tld should be updated to refer to the correct taglib implementation classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.