You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/17 08:53:54 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4214: Bug fixes for primate

davidjumani commented on a change in pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#discussion_r456311597



##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1064,9 +1062,8 @@
             sc.setParameters("keyPairName", keyPairName);
         }
 
-        if (cmd instanceof ListVMsCmdByAdmin) {
-            ListVMsCmdByAdmin aCmd = (ListVMsCmdByAdmin)cmd;
-            if (aCmd.getPodId() != null) {
+        if (_accountMgr.isRootAdmin(caller.getId())) {

Review comment:
       @rhtyd Is there a better way to do this? If not, can entirely remove ListVmsCmdByAdmin since it's no longer used




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org