You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Kirill Tkalenko (Jira)" <ji...@apache.org> on 2023/04/03 11:56:00 UTC

[jira] [Updated] (IGNITE-19181) ConfigurationNotificationEvent API is confusing

     [ https://issues.apache.org/jira/browse/IGNITE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kirill Tkalenko updated IGNITE-19181:
-------------------------------------
    Reviewer: Kirill Tkalenko

Looks good!

> ConfigurationNotificationEvent API is confusing
> -----------------------------------------------
>
>                 Key: IGNITE-19181
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19181
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ivan Bessonov
>            Assignee: Ivan Bessonov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Method `config` returns `*Configuration` class, which is no in line with the rest of the methods. `name` returns new name, unless it's a delete event, in that case it returns an old name. And it's not documented.
> I suggest using `*View` classes in the API, and split `name` into 2 methods, for old and new names.
> This will also allow to make `onRename` method simpler.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)