You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/07 09:08:32 UTC
[GitHub] [airflow] OmairK opened a new pull request #9651: Documentation for Google Cloud Data Loss Prevention
OmairK opened a new pull request #9651:
URL: https://github.com/apache/airflow/pull/9651
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-653770009
Still some checks to fix :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-654495526
> I have the impression that there are more DLP operators but they are not covered in the example DAG. I think we should add the documentation. I'm ok with not extending the DAG itself.
I have added documentation for all the DLP operators. Should I add other DAGs to extend the example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#discussion_r449797856
##########
File path: docs/howto/operator/gcp/data_loss_prevention.rst
##########
@@ -0,0 +1,92 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Google Cloud Data Loss Prevention Operator
+==========================================
+`Google Cloud DLP <https://cloud.google.com/dlp>`__, provides tools to classify, mask, tokenize, and transform sensitive
+elements to help you better manage the data that you collect, store, or use for business or analytics.
+
+.. contents::
+ :depth: 1
+ :local:
+
+Prerequisite Tasks
+^^^^^^^^^^^^^^^^^^
+
+.. include:: _partials/prerequisite_tasks.rst
+
+Templates
+^^^^^^^^^
+
+Templates can be used to create and persist
+configuration information to use with the Cloud Data Loss Prevention.
+There are two types of templates supported by Cloud DLP:
+
+* `Inspection Template <https://cloud.google.com/dlp/docs/creating-templates-inspect>`__,
+* `De-Identification Template <https://cloud.google.com/dlp/docs/creating-templates-deid>`__,
+
+Here we will be using identification template for our example
Review comment:
This information can be outdate in some future. So I would suggest to skip this section and let the user use the Google docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#discussion_r462958775
##########
File path: airflow/providers/google/cloud/example_dags/example_dlp.py
##########
@@ -66,20 +68,124 @@
do_xcom_push=True,
dag=dag,
)
+ # [END howto_operator_dlp_create_inspect_template]
+ # [START howto_operator_dlp_use_inspect_template]
inspect_content = CloudDLPInspectContentOperator(
task_id="inpsect_content",
project_id=GCP_PROJECT,
item=ITEM,
inspect_template_name="{{ task_instance.xcom_pull('create_template', key='return_value')['name'] }}",
dag=dag,
)
+ # [END howto_operator_dlp_use_inspect_template]
+ # [START howto_operator_dlp_delete_inspect_template]
delete_template = CloudDLPDeleteInspectTemplateOperator(
task_id="delete_template",
template_id=TEMPLATE_ID,
project_id=GCP_PROJECT,
dag=dag,
)
+ # [END howto_operator_dlp_delete_inspect_template]
create_template >> inspect_content >> delete_template
+
+
+custom_info_types = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[1-9]{3}-[1-9]{1}-[1-9]{5}"},
+ }
+]
+custom_info_type_id = "custom_info_type"
+update_custom_info_type = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[a-z]{3}-[a-z]{1}-[a-z]{5}"},
+ }
+]
+
+with models.DAG(
+ "example_gcp_dlp_info_types",
+ default_args=default_args,
+ schedule_interval=None,
+ tags=["example", "dlp", "info-types"],
+) as dag:
+ # [START howto_operator_dlp_create_info_type]
+ create_info_type = CloudDLPCreateStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ config=custom_info_types,
+ stored_info_type_id=custom_info_type_id,
+ dag=dag,
+ task_id="create_info_type",
+ )
+ # [END howto_operator_dlp_create_info_type]
+ # [START howto_operator_dlp_update_info_type]
+ update_info_type = CloudDLPUpdateStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ stored_info_type_id=custom_info_type_id,
+ config=update_custom_info_type,
+ dag=dag,
+ task_id="update_info_type",
+ )
+ # [END howto_operator_dlp_update_info_type]
+ # [START howto_operator_dlp_delete_info_type]
+ delete_info_type = CloudDLPDeleteStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ stored_info_type_id=custom_info_type_id,
+ dag=dag,
+ task_id="delete_info_type",
+ )
+ # [END howto_operator_dlp_delete_info_type]
+ create_info_type >> update_info_type >> delete_info_type
+
+SCHEDULE = {"recurrence_period_duration": {"seconds": 60 * 60 * 24}}
+JOB = {
+ "inspect_config": INSPECT_CONFIG,
+}
+
+JOB_TRIGGER = {
+ "inspect_job": JOB,
+ "triggers": [{"schedule": SCHEDULE}],
+ "status": "HEALTHY",
+}
+
+TRIGGER_ID = "example_trigger"
+
+with models.DAG(
+ "example_gcp_dlp_job",
+ default_args=default_args,
+ schedule_interval=None,
+ tags=["example", "dlp_job"],
+) as dag: # [START howto_operator_dlp_create_job_trigger]
+ create_trigger = CloudDLPCreateJobTriggerOperator(
+ project_id=GCP_PROJECT,
+ job_trigger=JOB_TRIGGER,
+ trigger_id=TRIGGER_ID,
+ dag=dag,
+ task_id="create_trigger",
+ )
Review comment:
This task fails with this error:
```
File "/airflow/airflow/providers/google/cloud/operators/dlp.py", line 433, in execute
metadata=self.metadata,
File "/airflow/airflow/providers/google/common/hooks/base_google.py", line 376, in inner_wrapper
return func(self, *args, **kwargs)
File "/airflow/airflow/providers/google/cloud/hooks/dlp.py", line 375, in create_job_trigger
metadata=metadata,
File "/.virtualenvs/airflow/lib/python3.6/site-packages/google/cloud/dlp_v2/gapic/dlp_service_client.py", line 2557, in create_job_trigger
request, retry=retry, timeout=timeout, metadata=metadata
File "/.virtualenvs/airflow/lib/python3.6/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
return wrapped_func(*args, **kwargs)
File "/.virtualenvs/airflow/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
six.raise_from(exceptions.from_grpc_error(exc), exc)
File "<string>", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 `StorageConfig` must be set.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-663773900
> Hey @OmairK - I re-run the latest commit run and there are few errors but not a mypy one :).
Thanks alot @potiuk, but this wasn't the PR with mypy errors. I have mentioned you there, sorry for the trouble.
I have extended the example dag and fixed the issue with the docs (I forgot to build docs after the rebase). Is there anything I could do to make the documentation better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9651:
URL: https://github.com/apache/airflow/pull/9651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#discussion_r462955385
##########
File path: airflow/providers/google/cloud/example_dags/example_dlp.py
##########
@@ -66,20 +68,124 @@
do_xcom_push=True,
dag=dag,
)
+ # [END howto_operator_dlp_create_inspect_template]
+ # [START howto_operator_dlp_use_inspect_template]
inspect_content = CloudDLPInspectContentOperator(
task_id="inpsect_content",
project_id=GCP_PROJECT,
item=ITEM,
inspect_template_name="{{ task_instance.xcom_pull('create_template', key='return_value')['name'] }}",
dag=dag,
)
+ # [END howto_operator_dlp_use_inspect_template]
+ # [START howto_operator_dlp_delete_inspect_template]
delete_template = CloudDLPDeleteInspectTemplateOperator(
task_id="delete_template",
template_id=TEMPLATE_ID,
project_id=GCP_PROJECT,
dag=dag,
)
+ # [END howto_operator_dlp_delete_inspect_template]
create_template >> inspect_content >> delete_template
+
+
+custom_info_types = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[1-9]{3}-[1-9]{1}-[1-9]{5}"},
+ }
+]
+custom_info_type_id = "custom_info_type"
+update_custom_info_type = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[a-z]{3}-[a-z]{1}-[a-z]{5}"},
+ }
+]
+
+with models.DAG(
+ "example_gcp_dlp_info_types",
+ default_args=default_args,
+ schedule_interval=None,
+ tags=["example", "dlp", "info-types"],
+) as dag:
+ # [START howto_operator_dlp_create_info_type]
+ create_info_type = CloudDLPCreateStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ config=custom_info_types,
+ stored_info_type_id=custom_info_type_id,
+ dag=dag,
+ task_id="create_info_type",
+ )
Review comment:
This task fails with:
```
File "/airflow/airflow/providers/google/cloud/hooks/dlp.py", line 432, in create_stored_info_type
metadata=metadata,
File ".virtualenvs/airflow/lib/python3.6/site-packages/google/cloud/dlp_v2/gapic/dlp_service_client.py", line 2625, in create_stored_info_type
parent=parent, config=config, stored_info_type_id=stored_info_type_id
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.privacy.dlp.v2.StoredInfoTypeConfig got list.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-680297740
@OmairK Can you do a rebase and leave a comment so we get notifications? Without it, we don't know that you've found the time to respond to our request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-653801160
I have the impression that there are more DLP operators but they are not covered in the example DAG. I think we should add the documentation. I'm ok with not extending the DAG itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-653800224
> Still some checks to fix :(
I fixed the static checks, one of the integration check is breaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-680302053
> @OmairK Can you do a rebase and leave a comment so we get notifications? Without it, we don't know that you've found the time to respond to our request.
@mik-laj I did the rebase. I informed @turbaszek via slack, I thought against sending two notifications for the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#discussion_r463206995
##########
File path: airflow/providers/google/cloud/example_dags/example_dlp.py
##########
@@ -66,20 +68,124 @@
do_xcom_push=True,
dag=dag,
)
+ # [END howto_operator_dlp_create_inspect_template]
+ # [START howto_operator_dlp_use_inspect_template]
inspect_content = CloudDLPInspectContentOperator(
task_id="inpsect_content",
project_id=GCP_PROJECT,
item=ITEM,
inspect_template_name="{{ task_instance.xcom_pull('create_template', key='return_value')['name'] }}",
dag=dag,
)
+ # [END howto_operator_dlp_use_inspect_template]
+ # [START howto_operator_dlp_delete_inspect_template]
delete_template = CloudDLPDeleteInspectTemplateOperator(
task_id="delete_template",
template_id=TEMPLATE_ID,
project_id=GCP_PROJECT,
dag=dag,
)
+ # [END howto_operator_dlp_delete_inspect_template]
create_template >> inspect_content >> delete_template
+
+
+custom_info_types = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[1-9]{3}-[1-9]{1}-[1-9]{5}"},
+ }
+]
+custom_info_type_id = "custom_info_type"
+update_custom_info_type = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[a-z]{3}-[a-z]{1}-[a-z]{5}"},
+ }
+]
+
+with models.DAG(
+ "example_gcp_dlp_info_types",
+ default_args=default_args,
+ schedule_interval=None,
+ tags=["example", "dlp", "info-types"],
+) as dag:
+ # [START howto_operator_dlp_create_info_type]
+ create_info_type = CloudDLPCreateStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ config=custom_info_types,
+ stored_info_type_id=custom_info_type_id,
+ dag=dag,
+ task_id="create_info_type",
+ )
Review comment:
I agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#discussion_r462959909
##########
File path: airflow/providers/google/cloud/example_dags/example_dlp.py
##########
@@ -66,20 +68,124 @@
do_xcom_push=True,
dag=dag,
)
+ # [END howto_operator_dlp_create_inspect_template]
+ # [START howto_operator_dlp_use_inspect_template]
inspect_content = CloudDLPInspectContentOperator(
task_id="inpsect_content",
project_id=GCP_PROJECT,
item=ITEM,
inspect_template_name="{{ task_instance.xcom_pull('create_template', key='return_value')['name'] }}",
dag=dag,
)
+ # [END howto_operator_dlp_use_inspect_template]
+ # [START howto_operator_dlp_delete_inspect_template]
delete_template = CloudDLPDeleteInspectTemplateOperator(
task_id="delete_template",
template_id=TEMPLATE_ID,
project_id=GCP_PROJECT,
dag=dag,
)
+ # [END howto_operator_dlp_delete_inspect_template]
create_template >> inspect_content >> delete_template
+
+
+custom_info_types = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[1-9]{3}-[1-9]{1}-[1-9]{5}"},
+ }
+]
+custom_info_type_id = "custom_info_type"
+update_custom_info_type = [
+ {
+ "info_type": {"name": "C_MRN"},
+ "regex": {"pattern": "[a-z]{3}-[a-z]{1}-[a-z]{5}"},
+ }
+]
+
+with models.DAG(
+ "example_gcp_dlp_info_types",
+ default_args=default_args,
+ schedule_interval=None,
+ tags=["example", "dlp", "info-types"],
+) as dag:
+ # [START howto_operator_dlp_create_info_type]
+ create_info_type = CloudDLPCreateStoredInfoTypeOperator(
+ project_id=GCP_PROJECT,
+ config=custom_info_types,
+ stored_info_type_id=custom_info_type_id,
+ dag=dag,
+ task_id="create_info_type",
+ )
Review comment:
I'm happy to help with solving this but probably it would be best if the same person who develops the DAG run the DAG to verify if the example works. @mik-laj @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-654496647
@OmairK Example tasks for the rest operators will be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-663041511
Hey @OmairK - I re-run the latest commit run and there are few errors but not a mypy one :).
1) You will need to rebase to latest master, there were some changes in Dockerfile/requirements recently that will make your CI checks run much faster when you rebase.
2) You have some trailing whitespace - that's why the static checks fail. But if you install pre-commit locally and run it with --all-files those should get fixed automatically.
3) There are some doc errors - all of them have good description, except one that is "document missing in a TOC tree" - you need to add a link to the dlp index in the relevant place in one of the doc/*.rst files.
4) In the "Backport packages" you have an import error from the example dag of dlp - and the reason is that task_id parameter is missing in the example_dlp.
I hope it's helpful.
J.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-679032728
@OmairK would you mind rebasing? I'm ok with merging this PR with not working system tests. We need them to debug the DLP operators that are reported to be not working properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-654711785
> @OmairK Example tasks for the rest operators will be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-680930654
> @OmairK will you be able to fix the statics checks?
@turbaszek Done :sweat_smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-680770655
@OmairK will you be able to fix the statics checks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek closed pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek closed pull request #9651:
URL: https://github.com/apache/airflow/pull/9651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek removed a comment on pull request #9651: Documentation for Google Cloud Data Loss Prevention
Posted by GitBox <gi...@apache.org>.
turbaszek removed a comment on pull request #9651:
URL: https://github.com/apache/airflow/pull/9651#issuecomment-654711785
> @OmairK Example tasks for the rest operators will be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org