You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Rae Egli <re...@yahoo.com> on 2008/09/03 17:02:34 UTC

Re: HttpCore - #setUri method

Oleg,

Thanks very much for your input.  I would prefer adding it to BasicHttpRequest as it appears to me to be part of essential HttpCore functionality.  It seems to me that any process with more extensive proxy facilities would need such a method, just think of handling http ver 1.0 hosts.

Thanks again.

Rae



----- Original Message ----
From: Oleg Kalnichevski <ol...@apache.org>
To: HttpComponents Project <de...@hc.apache.org>
Sent: Wednesday, September 3, 2008 3:34:42 AM
Subject: Re: HttpCore -

On Tue, 2008-09-02 at 19:20 -0700, Rae Egli wrote:
> I am trying to relativize a URI in an existing request.  BasicHttpRequest contains the instance variable uri but it is private and final.  
> 
> Wouldn't it make sense to allow the URI in a request to be changed, i.e. provide a setUri method in BasicHttpRequest?
> 
> Thanks for any suggestions.
> 
> Rae

Hi Rae,

Yes, this can be done. However, you should probably just use a custom
impl of the HttpRequest interface with additional methods required by
your application. I do not see a problem with adding #setUri method to
the BasicHttpRequest class either.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: HttpCore - #setUri method

Posted by Bob Lee <cr...@crazybob.org>.
On Fri, Sep 5, 2008 at 4:34 PM, Oleg Kalnichevski <ol...@apache.org> wrote:

> Bad news. I'll have to revert this change due to the objection raised by
> Bob Lee of the Android project. This change rendered HttpCore
> incompatible with the version shipped with Google Android.
>

FWIW, we modify the URI of a request using RequestWrapper.

Thanks,
Bob

Re: HttpCore - #setUri method

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2008-09-05 at 20:10 +0200, Oleg Kalnichevski wrote:
> On Wed, 2008-09-03 at 08:02 -0700, Rae Egli wrote:
> > Oleg,
> > 
> > Thanks very much for your input.  I would prefer adding it to BasicHttpRequest as it appears to me to be part of essential HttpCore functionality.  It seems to me that any process with more extensive proxy facilities would need such a method, just think of handling http ver 1.0 hosts.
> > 
> > Thanks again.
> > 
> > Rae
> > 
> 
> OK. Done. Please pull the latest snapshot off the SVN trunk and let me
> know if that fixes the problem for you.
> 
> Oleg
> 

Bad news. I'll have to revert this change due to the objection raised by
Bob Lee of the Android project. This change rendered HttpCore
incompatible with the version shipped with Google Android.  

My bad. Sorry.

Oleg

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: HttpCore - #setUri method

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Wed, 2008-09-03 at 08:02 -0700, Rae Egli wrote:
> Oleg,
> 
> Thanks very much for your input.  I would prefer adding it to BasicHttpRequest as it appears to me to be part of essential HttpCore functionality.  It seems to me that any process with more extensive proxy facilities would need such a method, just think of handling http ver 1.0 hosts.
> 
> Thanks again.
> 
> Rae
> 

OK. Done. Please pull the latest snapshot off the SVN trunk and let me
know if that fixes the problem for you.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org