You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/24 05:06:40 UTC
[GitHub] [shardingsphere-on-cloud] xuanyuan300 opened a new pull request, #111: feat(cloudformation): add support for multi-az mode for cloudformation.
xuanyuan300 opened a new pull request, #111:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/111
Signed-off-by: xuanyuan300 <xu...@gmail.com>
<!-- Please answer these questions before submitting a pull request -->
Add support for multi-az mode for cloudformation.
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #111: feat(cloudformation): add support for multi-az mode for cloudformation.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #111:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/111#issuecomment-1325964632
# [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#111](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/111?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09ba63c) into [main](https://codecov.io/gh/apache/shardingsphere-on-cloud/commit/ffb31ea7ee4aa1bb0b61640d994c2cf0c4285505?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffb31ea) will **increase** coverage by `4.47%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 51.49% 55.97% +4.47%
==========================================
Files 2 2
Lines 268 268
==========================================
+ Hits 138 150 +12
+ Misses 128 116 -12
Partials 2 2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [shardingsphere-operator/pkg/reconcile/resource.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9yZXNvdXJjZS5nbw==) | `53.17% <0.00%> (+4.76%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] xuanyuan300 commented on pull request #111: feat(cloudformation): add support for multi-az mode for cloudformation.
Posted by GitBox <gi...@apache.org>.
xuanyuan300 commented on PR #111:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/111#issuecomment-1326196225
> About cloud-init directives:
>
> > The #cloud-config line at the top is required in order to identify the commands as cloud-init directives.
>
> link: [aws docs](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/user-data.html)
About the location of `#cloud-config`, please check [link](https://www.digitalocean.com/community/tutorials/how-to-use-cloud-config-for-your-initial-server-setup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on pull request #111: feat(cloudformation): add support for multi-az mode for cloudformation.
Posted by GitBox <gi...@apache.org>.
mlycore commented on PR #111:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/111#issuecomment-1326155056
About cloud-init directives:
> The #cloud-config line at the top is required in order to identify the commands as cloud-init directives.
link: [aws docs](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/user-data.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] zhaojinchao95 merged pull request #111: feat(cloudformation): add support for multi-az mode for cloudformation.
Posted by GitBox <gi...@apache.org>.
zhaojinchao95 merged PR #111:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org