You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/03 20:53:33 UTC
Review Request 28663: Cleaned up the utility structs in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28663/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
When I originally suggested adding these on Thomas' review, I didn't consider adding these inline.
Placing these inline as pure data structs, as we've done elsewhere, cleans this up quite a bit.
Diffs
-----
src/master/hierarchical_allocator_process.hpp fbaa23fad37fc6cbe870932cd4ace6622080001b
Diff: https://reviews.apache.org/r/28663/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28663: Cleaned up the utility structs in the
allocator.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 3, 2014, 10:07 p.m., Jie Yu wrote:
> > src/master/hierarchical_allocator_process.hpp, lines 423-432
> > <https://reviews.apache.org/r/28663/diff/1/?file=781872#file781872line423>
> >
> > This is in the header file which can polute the namespace. Probably either put that in the HierarchicalAllocatorProcess class (static method), or simply calculate 'available' manually below.
Thanks! I'll put it in an internal namespace for now.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28663/#review63753
-----------------------------------------------------------
On Dec. 3, 2014, 7:53 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28663/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When I originally suggested adding these on Thomas' review, I didn't consider adding these inline.
>
> Placing these inline as pure data structs, as we've done elsewhere, cleans this up quite a bit.
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp fbaa23fad37fc6cbe870932cd4ace6622080001b
>
> Diff: https://reviews.apache.org/r/28663/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28663: Cleaned up the utility structs in the
allocator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28663/#review63753
-----------------------------------------------------------
Ship it!
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/28663/#comment106051>
This is in the header file which can polute the namespace. Probably either put that in the HierarchicalAllocatorProcess class (static method), or simply calculate 'available' manually below.
- Jie Yu
On Dec. 3, 2014, 7:53 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28663/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When I originally suggested adding these on Thomas' review, I didn't consider adding these inline.
>
> Placing these inline as pure data structs, as we've done elsewhere, cleans this up quite a bit.
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp fbaa23fad37fc6cbe870932cd4ace6622080001b
>
> Diff: https://reviews.apache.org/r/28663/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>