You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/20 20:25:55 UTC

[GitHub] [accumulo-testing] DomGarguilo opened a new pull request #155: Fix performance test NumberFormatException bug

DomGarguilo opened a new pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155


   Closes #154 
   
   * Manually convert from nanoseconds to seconds to preserve precision of timing.
   * Fixed average for first set of 1-19 runs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] ctubbsii commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712630704



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -150,7 +150,9 @@ public static double conditionalMutationsTime(ConditionalWriter cw, long seq) th
 
     long t2 = System.nanoTime();
 
-    return 10000.0 / TimeUnit.NANOSECONDS.toSeconds(t2 - t1);
+    double nanosPerSec = (double) TimeUnit.SECONDS.toNanos(1);
+    // return number of conditions per second
+    return 10000.0 / ((t2 - t1) / nanosPerSec);

Review comment:
       > Alternatively, why not perform the calculation in nanos and convert the rate at the end?
   
   Because then you'd risk losing precision scaling down when you divide by the nanosecond duration only to multiply by 1E9 to scale back up to seconds. And also, it's much more readable to simply compute the number of seconds, and literally return `numEvents / seconds` to get the number of events per second, rather than convert `events/ns` to `events/s` by multiplying by `ns/s`.
   
   For reference, the code that works in `events/ns` first:
   
   ```java
   private static double rate(long numEvents, long startNanos, long stopNanos) {
     double eventsPerNano = numEvents / ((double) t2 - t1);
     double nanosPerSec = 1.0E9; // or (double) TimeUnit.SECONDS.toNanos(1);
     return eventsPerNano * nanosPerSec;
   }
   ```
   
   Every line that differs here from the previous suggestion is more confusing. My earlier suggestion was substantially more straight-forward.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712548881



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       The first test run just seems to cover the default test case or to get a baseline. ConitionalMutation will always have an initial seq value of 1 because of it. The devisor should probably stay at 20 if we wish to keep the first test case but I haven't done any testing on it. 
   Edit: I forgot the point of that specific rateSum not being collected, which kind of makes my point irrelevant. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712548881



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       The first test run just seems to cover the default test case or to get a baseline. ConitionalMutation will always have an initial seq value of 1 because of it. The devisor should probably stay at 20 if we wish to keep the first test case but I haven't done any testing on it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r713100968



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -150,7 +150,9 @@ public static double conditionalMutationsTime(ConditionalWriter cw, long seq) th
 
     long t2 = System.nanoTime();
 
-    return 10000.0 / TimeUnit.NANOSECONDS.toSeconds(t2 - t1);
+    double nanosPerSec = (double) TimeUnit.SECONDS.toNanos(1);
+    // return number of conditions per second
+    return 10000.0 / ((t2 - t1) / nanosPerSec);

Review comment:
       Addressed in dc41ea0 and 27f49d6




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] ctubbsii commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r715007299



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -93,34 +93,37 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
         new ConditionalWriterConfig());
 
+    // warm-up run
     conditionalMutationsTime(cw, 0);
 
     double rateSum = 0.0;
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {
       rateSum += conditionalMutationsTime(cw, i);
     }
 
-    reportBuilder.result("avgRate: 1-19",
+    reportBuilder.result("avgRate: 1-20",
         Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
-        "ConditionalMutationsTest: average rate (conditions/sec) to run sequence 1-19");
+        "ConditionalMutationsTest: average rate (conditions/sec) to run sequence 1-20");
 
     env.getClient().tableOperations().flush(tableName, null, null, true);
 
     rateSum = 0.0;
-    for (long i = 20; i < 40; i++) {
+    for (long i = 21; i < 41; i++) {

Review comment:
       ```suggestion
       for (long i = 21; i <= 40; i++) {
   ```

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -248,43 +256,46 @@ private static void runRandomizeBatchScanAndWriteTest(Environment env, String ta
     BatchWriter bw = env.getClient().createBatchWriter(tableName, new BatchWriterConfig());
     BatchScanner bs = env.getClient().createBatchScanner(tableName, Authorizations.EMPTY, 1);
 
+    // warm-up run
     randomizeBatchWriteAndScanTime(bw, bs, 0);
 
     double rateSum = 0;
 
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {

Review comment:
       ```suggestion
       for (long i = 1; i <= 20; i++) {
   ```

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -248,43 +256,46 @@ private static void runRandomizeBatchScanAndWriteTest(Environment env, String ta
     BatchWriter bw = env.getClient().createBatchWriter(tableName, new BatchWriterConfig());
     BatchScanner bs = env.getClient().createBatchScanner(tableName, Authorizations.EMPTY, 1);
 
+    // warm-up run
     randomizeBatchWriteAndScanTime(bw, bs, 0);
 
     double rateSum = 0;
 
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {
       rateSum += randomizeBatchWriteAndScanTime(bw, bs, i);
     }
 
-    reportBuilder.result("avgRate: 1-19",
+    reportBuilder.result("avgRate: 1-20",
         Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
-        "RandomizeBatchScanAndWriteTest: average rate (conditions/sec)  to write and scan sequence 1-19");
+        "RandomizeBatchScanAndWriteTest: average rate (conditions/sec) to write and scan sequence 1-20");
 
     env.getClient().tableOperations().flush(tableName, null, null, true);
 
     rateSum = 0;
-    for (long i = 20; i < 40; i++) {
+    for (long i = 21; i < 41; i++) {

Review comment:
       ```suggestion
       for (long i = 21; i <= 40; i++) {
   ```

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -93,34 +93,37 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
         new ConditionalWriterConfig());
 
+    // warm-up run
     conditionalMutationsTime(cw, 0);
 
     double rateSum = 0.0;
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {

Review comment:
       I think it might be intuitive if `<=` were used:
   ```suggestion
       for (long i = 1; i <= 20; i++) {
   ```

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -165,42 +169,45 @@ private static void runRandomizeConditionalMutationsTest(Environment env, String
     ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
         new ConditionalWriterConfig());
 
+    // warm-up run
     randomizeConditionalMutationsTime(cw, 0);
 
     double rateSum = 0;
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {

Review comment:
       ```suggestion
       for (long i = 1; i <= 20; i++) {
   ```

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -165,42 +169,45 @@ private static void runRandomizeConditionalMutationsTest(Environment env, String
     ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
         new ConditionalWriterConfig());
 
+    // warm-up run
     randomizeConditionalMutationsTime(cw, 0);
 
     double rateSum = 0;
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {
       rateSum += randomizeConditionalMutationsTime(cw, i);
     }
 
-    reportBuilder.result("avgRate: 1-19",
+    reportBuilder.result("avgRate: 1-20",
         Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
-        "RandomizeConditionalMutationsTest: average rate (conditions/sec)  to run sequence 1-19");
+        "RandomizeConditionalMutationsTest: average rate (conditions/sec) to run sequence 1-20");
 
     env.getClient().tableOperations().flush(tableName, null, null, true);
 
     rateSum = 0;
-    for (long i = 20; i < 40; i++) {
+    for (long i = 21; i < 41; i++) {

Review comment:
       ```suggestion
       for (long i = 21; i <= 40; i++) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712996058



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       I'm not sure why the first set only runs 19 times, I just thought I would fix the average calculation. I can go through and bump all the numbers up by 1 so that all runs are performed 20 times for consistency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r715019317



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -93,34 +93,37 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
         new ConditionalWriterConfig());
 
+    // warm-up run
     conditionalMutationsTime(cw, 0);
 
     double rateSum = 0.0;
-    for (long i = 1; i < 20; i++) {
+    for (long i = 1; i < 21; i++) {

Review comment:
       Good idea, definitely more intuitive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712593680



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       That seems reasonable. Do we do that for other Performance Tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] ctubbsii commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712524139



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       It's weird that we run it 20 times, once before the loop of 19, but not collecting the sum for that first run. I'm not sure how to interpret the intent here without comments in the code. Without a better understanding of why we're doing that, it's not clear if the divisor should be changed or not.

##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -150,7 +150,9 @@ public static double conditionalMutationsTime(ConditionalWriter cw, long seq) th
 
     long t2 = System.nanoTime();
 
-    return 10000.0 / TimeUnit.NANOSECONDS.toSeconds(t2 - t1);
+    double nanosPerSec = (double) TimeUnit.SECONDS.toNanos(1);
+    // return number of conditions per second
+    return 10000.0 / ((t2 - t1) / nanosPerSec);

Review comment:
       This would be more readable in a new method that can be reused more readably:
   
   ```java
   return rate(numEvents, startNanos, stopNanos);
   ```
   
   The method could look something like:
   
   ```java
   private static double rate(long numEvents, long startNanos, long stopNanos) {
     double nanosPerSec = 1.0E9; // or (double) TimeUnit.SECONDS.toNanos(1)
     double seconds = (t2 - t1) / nanosPerSec;
     return numEvents / seconds;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] keith-turner commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712575317



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       > It's weird that we run it 20 times, once before the loop of 19, but not collecting the sum for that first run.
   
   I suspect the first run is done to warm up the JVMs (like make the JIT kick in) and its time is ignored.  Then the times from the next 19 runs are used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r713101326



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       Addressed in dc41ea0




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r713000513



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -150,7 +150,9 @@ public static double conditionalMutationsTime(ConditionalWriter cw, long seq) th
 
     long t2 = System.nanoTime();
 
-    return 10000.0 / TimeUnit.NANOSECONDS.toSeconds(t2 - t1);
+    double nanosPerSec = (double) TimeUnit.SECONDS.toNanos(1);
+    // return number of conditions per second
+    return 10000.0 / ((t2 - t1) / nanosPerSec);

Review comment:
       What about a method to just convert from nanos to seconds? That might make things even more readable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] ctubbsii commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712626873



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment env, String tableNam
     }
 
     reportBuilder.result("avgRate: 1-19",
-        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+        Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),

Review comment:
       Warming up seems reasonable. I just don't know why we have 19 subsequent runs. It might make sense to just round the number of runs off to 20, rather than use 19 as a divisor, which is a little confusing. The warm-up run would benefit from an inline comment like `// warm-up run`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] EdColeman commented on a change in pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712591960



##########
File path: src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -150,7 +150,9 @@ public static double conditionalMutationsTime(ConditionalWriter cw, long seq) th
 
     long t2 = System.nanoTime();
 
-    return 10000.0 / TimeUnit.NANOSECONDS.toSeconds(t2 - t1);
+    double nanosPerSec = (double) TimeUnit.SECONDS.toNanos(1);
+    // return number of conditions per second
+    return 10000.0 / ((t2 - t1) / nanosPerSec);

Review comment:
       Alternatively, why not perform the calculation in nanos and convert the rate at the end?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] DomGarguilo merged pull request #155: Fix performance test NumberFormatException bug

Posted by GitBox <gi...@apache.org>.
DomGarguilo merged pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org