You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/07 13:06:42 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #40318: [SPARK-42656][SPARK SHELL][CONNECT][FOLLOWUP] Add same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13
LuciferYang opened a new pull request, #40318:
URL: https://github.com/apache/spark/pull/40318
### What changes were proposed in this pull request?
This pr add the same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13 as https://github.com/apache/spark/pull/40305 due `org/apache/spark/repl/Main.scala` is Scala version sensitive。
### Why are the changes needed?
Make sure Scala 2.12 and 2.13 have the same logic
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40318: [SPARK-42656][SPARK SHELL][CONNECT][FOLLOWUP] Add same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40318:
URL: https://github.com/apache/spark/pull/40318#discussion_r1127827370
##########
repl/src/main/scala-2.13/org/apache/spark/repl/Main.scala:
##########
@@ -129,6 +129,11 @@ object Main extends Logging {
sparkContext = sparkSession.sparkContext
sparkSession
} catch {
+ case e: ClassNotFoundException if isShellSession && e.getMessage.contains(
Review Comment:
cc @hvanhovell @zhenlineo I think Scala 2.13 need same change as https://github.com/apache/spark/pull/40305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #40318: [SPARK-42656][SPARK SHELL][CONNECT][FOLLOWUP] Add same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #40318: [SPARK-42656][SPARK SHELL][CONNECT][FOLLOWUP] Add same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13
URL: https://github.com/apache/spark/pull/40318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org