You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/04/19 15:07:10 UTC
[I] python: consider adding back a na.array(..) constructor [arrow-nanoarrow]
jorisvandenbossche opened a new issue, #434:
URL: https://github.com/apache/arrow-nanoarrow/issues/434
While writing the example for our tutorial, the usage of `na.Array(..)` stood a bit out. There is of course nothing "wrong" with it, but it does feel inconsistent with how many other libraries provide their general purpose constructor (eg `pyarrow.array()`, `numpy.array()`, `torch.tensor()`, etc), and also somewhat internally with most or our other constructors (eg `na.c_array()` and not `na.CArray()`, and several other such cases)
So the suggestion to consider adding again a `nanoarrow.array(..) -> Array` constructor function (I think at some point in the Array PR it did exist?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] python: consider adding back a na.array(..) constructor [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #434:
URL: https://github.com/apache/arrow-nanoarrow/issues/434#issuecomment-2066921779
I forget exactly which review suggested I drop it (perhaps from @danepitkin ?), but I don't have strong feelings either way. Right now it gives a very bad error message (below), so I'm inclined to add it back (but perhaps keeping the documentation with the `Array` constructor?).
```python
import nanoarrow as na
na.array([1, 2, 3], na.int32())
#> TypeError: 'module' object is not callable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] python: consider adding back a na.array(..) constructor [arrow-nanoarrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche closed issue #434: python: consider adding back a na.array(..) constructor
URL: https://github.com/apache/arrow-nanoarrow/issues/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org