You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sarutak <gi...@git.apache.org> on 2014/11/05 11:16:35 UTC
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
GitHub user sarutak opened a pull request:
https://github.com/apache/incubator-flink/pull/180
[FLINK-1212] Interpreter directive in shell scripts should be "/usr/bin/env bash" instead of "/bin/bash"
There are some scripts which interpreter directive are "#!/bin/bash". We should use "#!/usr/bin/env bash" instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/incubator-flink sh-directive-modification
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
----
commit 5a80b025f85bf3e9a71a50fe94eaa14a77a1b92a
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-11-05T10:13:03Z
Fixed shell script interpreter directive
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/180#issuecomment-62364389
Ah. The issue hasn't been merged to Flink. @StephanEwen referenced to it from his "incubator-flink" branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/180#issuecomment-62123798
Will merge this one...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/180#issuecomment-62364307
Can you close the pull request manually? It seems like GitHub is unable to detect the close comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1212] Interpreter directive i...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/180#issuecomment-61786792
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---