You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/03/14 23:05:08 UTC

Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57627/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Currently the CNI isolator identifies the "__MESOS_TEST__" as a test
network. However, there are cases where we might need multiple test
networks to test against. To support this use case we now do a
substring match on the network name and treat any network with name of
the form "*__MESOS_TEST__*" as a test network.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147 


Diff: https://reviews.apache.org/r/57627/diff/1/


Testing
-------

sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*


Thanks,

Avinash sridharan


Re: Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57627/#review169171
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On March 14, 2017, 11:05 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57627/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 11:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently the CNI isolator identifies the "__MESOS_TEST__" as a test
> network. However, there are cases where we might need multiple test
> networks to test against. To support this use case we now do a
> substring match on the network name and treat any network with name of
> the form "*__MESOS_TEST__*" as a test network.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147 
> 
> 
> Diff: https://reviews.apache.org/r/57627/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57627/
-----------------------------------------------------------

(Updated March 14, 2017, 11:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6022
    https://issues.apache.org/jira/browse/MESOS-6022


Repository: mesos


Description
-------

Currently the CNI isolator identifies the "__MESOS_TEST__" as a test
network. However, there are cases where we might need multiple test
networks to test against. To support this use case we now do a
substring match on the network name and treat any network with name of
the form "*__MESOS_TEST__*" as a test network.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147 


Diff: https://reviews.apache.org/r/57627/diff/1/


Testing
-------

sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*


Thanks,

Avinash sridharan