You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/05/29 21:54:31 UTC
[kudu-CR] [java] Improve TestAsyncKuduSession: Refactor into more tests
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13460
Change subject: [java] Improve TestAsyncKuduSession: Refactor into more tests
......................................................................
[java] Improve TestAsyncKuduSession: Refactor into more tests
TestAsyncKuduSession had a few tests, but one of them, ominously called
`test`, was actually 7-8 tests in one, with each test shackled to the
next by the shared state of the underlying table. The main improvement
of this commit is to refactor mega-`test` into several targeted tests.
There were some parts of the original mega test method for which I
couldn't determine what precisely they were testing. Those parts have
been dropped.
I also made a few other small improvements which allowed me to drop
almost all the helper code in favor of generic test utils.
Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
1 file changed, 150 insertions(+), 291 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/13460/1
--
To view, visit http://gerrit.cloudera.org:8080/13460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009
Gerrit-Change-Number: 13460
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Improve TestAsyncKuduSession: Refactor into more tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13460 )
Change subject: [java] Improve TestAsyncKuduSession: Refactor into more tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009
Gerrit-Change-Number: 13460
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 May 2019 22:08:39 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Improve TestAsyncKuduSession: Refactor into more tests
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13460 )
Change subject: [java] Improve TestAsyncKuduSession: Refactor into more tests
......................................................................
[java] Improve TestAsyncKuduSession: Refactor into more tests
TestAsyncKuduSession had a few tests, but one of them, ominously called
`test`, was actually 7-8 tests in one, with each test shackled to the
next by the shared state of the underlying table. The main improvement
of this commit is to refactor mega-`test` into several targeted tests.
There were some parts of the original mega test method for which I
couldn't determine what precisely they were testing. Those parts have
been dropped.
I also made a few other small improvements which allowed me to drop
almost all the helper code in favor of generic test utils.
Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009
Reviewed-on: http://gerrit.cloudera.org:8080/13460
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
1 file changed, 150 insertions(+), 291 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73675605c04d16f23ce9cd61763a97486dfcb009
Gerrit-Change-Number: 13460
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>