[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15772: [Refactor](table function) Decouple vectorized table functions from non-vectorized ones

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15772:
URL: https://github.com/apache/doris/pull/15772#discussion_r1065530921


##########
be/src/vec/exprs/table_function/vexplode_split.h:
##########
@@ -17,27 +17,28 @@
 
 #pragma once
 
-#include "exprs/table_function/explode_split.h"
 #include "gutil/strings/stringpiece.h"
 #include "runtime/string_value.h"
 #include "vec/columns/column.h"
+#include "vec/exprs/table_function/table_function.h"
 
 namespace doris::vectorized {
 
-class VExplodeSplitTableFunction : public ExplodeSplitTableFunction {
+class VExplodeSplitTableFunction final : public TableFunction {
 public:
     VExplodeSplitTableFunction();
-    virtual ~VExplodeSplitTableFunction() = default;
+    ~VExplodeSplitTableFunction() = default;

Review Comment:
   warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
   
   ```suggestion
       ~VExplodeSplitTableFunction() override = default;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org