[GitHub] [apisix-docker] gxthrj commented on a change in pull request #140: ci: refactor ci and compose

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r583388704



##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
 #
 default: help
 
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest

Review comment:
       The version should be 2.3
   We discussed before and decided to modify this version number to trigger CI after each APISIX release.

##########
File path: .github/workflows/apisix-docker-test.yaml
##########
@@ -10,17 +10,32 @@ on:
 
 jobs:
   build:
+    strategy:
+      fail-fast: false
+      matrix:
+        platform:
+          - alpine
+          - centos
+          - alpine-local
+
     runs-on: ubuntu-latest
+    env:
+      APISIX_PATH: "./apisix-local"
     steps:
       - uses: actions/checkout@v2
-      - name: Build and run
+
+      - name: Clone apisix for local test
+        if: ${{ matrix.platform == 'alpine-local' }}
         run: |
           git clone http://github.com/apache/apisix apisix-local
-          export APISIX_PATH="./apisix-local"
-          make build-on-alpine-local
-          docker-compose -f ./alpine-local/docker-compose.yaml up -d
+
+      - name: Build and run
+        run: |
+          make build-on-${{ matrix.platform }}

Review comment:
       👍




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org