You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/11 17:59:04 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #384: [YUNIKORN-1112] Use K8s ENV vars to locate yunikorn service from within admission controller
craigcondit opened a new pull request #384:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/384
### What is this PR for?
In certain networking environments (such as EKS with Calico), the yunikorn-service DNS entry is unavailable within the admission controller when running in the host network. However, we can use Kubernetes ENV vars to locate the service.
This patch uses `YUNIKORN_SERVICE_SERVICE_HOST` and `YUNIKORN_SERVICE_SERVICE_PORT` in preference to `SCHEDULER_SERVICE_ADDRESS` if present.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1112
### How should this be tested?
Verified with local deployment using the new syntax.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit closed pull request #384: [YUNIKORN-1112] Use K8s ENV vars to locate yunikorn service from within admission controller
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #384:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #384: [YUNIKORN-1112] Use K8s ENV vars to locate yunikorn service from within admission controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #384:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/384#issuecomment-1065359097
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#384](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fff8a5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5d89c9c9a12c3ec90ddd85541cdb9ce2060ea4a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d89c9c) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 64.89% 64.83% -0.07%
==========================================
Files 41 41
Lines 6267 6273 +6
==========================================
Hits 4067 4067
- Misses 2044 2050 +6
Partials 156 156
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/plugin/admissioncontrollers/webhook/webhook.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2suZ28=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5d89c9c...5fff8a5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/384?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #384: [YUNIKORN-1112] Use K8s ENV vars to locate yunikorn service from within admission controller
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #384:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/384#issuecomment-1065371492
Withdrawing patch as this will not survive service restarts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org