[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #9: [WIP] express plugin, make spans actually work

[GitBox <gi...@apache.org>]

tom-pytel edited a comment on pull request #9:
URL: https://github.com/apache/skywalking-nodejs/pull/9#issuecomment-739328787


   I did not differentiate https from http in any way in terms of identifying itself as http and it lives in the same module because it is literally the same code just applied to a different built-in module.
   
   Also, I noticed there exists a specific component definition for NodeJS http server:
   ```yml
   HttpServer:
     id: 4001
     languages: Node.js
   ```
   But the one actually used in the http plugin is #49:
   ```yml
   http:
     id: 49
     languages: Java,C#,Node.js
   ```
   And the client used is # 2.
   
   Which way do you guys want to go with this, more specific for the individual languages or should all language-common base protocols be the same (# 2 and # 49)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org