You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/18 16:30:02 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4850: [MINOR] Fixing checkpoint management in hoodie incr source
nsivabalan opened a new pull request #4850:
URL: https://github.com/apache/hudi/pull/4850
## What is the purpose of the pull request
Fixing the return value for checkpoint when checkpoint has not changed. bug was introduced in one of the previous refactoring patch. does not affect any of the official releases.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044799388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044799388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1045181564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
}, {
"hash" : "699533577f5c5c341790b9bf86eea1a51171940e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133",
"triggerID" : "699533577f5c5c341790b9bf86eea1a51171940e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
* 699533577f5c5c341790b9bf86eea1a51171940e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1045275027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
}, {
"hash" : "699533577f5c5c341790b9bf86eea1a51171940e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133",
"triggerID" : "699533577f5c5c341790b9bf86eea1a51171940e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 699533577f5c5c341790b9bf86eea1a51171940e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044803667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1045181564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
}, {
"hash" : "699533577f5c5c341790b9bf86eea1a51171940e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133",
"triggerID" : "699533577f5c5c341790b9bf86eea1a51171940e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
* 699533577f5c5c341790b9bf86eea1a51171940e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6133)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044915730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044915730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1046295819
@harsh1231 : can you review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1044803667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1045176798
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
}, {
"hash" : "699533577f5c5c341790b9bf86eea1a51171940e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "699533577f5c5c341790b9bf86eea1a51171940e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
* 699533577f5c5c341790b9bf86eea1a51171940e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4850:
URL: https://github.com/apache/hudi/pull/4850#issuecomment-1045176798
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132",
"triggerID" : "53299b20c514a253623c539c7f7e1a69be87dc3a",
"triggerType" : "PUSH"
}, {
"hash" : "699533577f5c5c341790b9bf86eea1a51171940e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "699533577f5c5c341790b9bf86eea1a51171940e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53299b20c514a253623c539c7f7e1a69be87dc3a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6132)
* 699533577f5c5c341790b9bf86eea1a51171940e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4850: [HUDI-3455] Fixing checkpoint management in hoodie incr source
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4850:
URL: https://github.com/apache/hudi/pull/4850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org