You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/01/28 15:33:39 UTC
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/482
Wait for STOP effector to complete before unamanging BrooklynNode
Otherwise if there still are running tasks for the entity they will be canceled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/brooklynnode-unmanage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
----
commit 91a8c81bcdda9ea14f620c7c7116d9883638daee
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-01-28T14:31:57Z
Wait for STOP effector to complete before unamanging BrooklynNode
Otherwise if there still are running tasks for the entity they will be canceled.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/482#discussion_r23767028
--- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java ---
@@ -81,9 +84,25 @@
RendererHints.register(WEB_CONSOLE_URI, RendererHints.namedActionWithUrl());
}
- private class UnmanageThread extends Thread {
+ private static class UnmanageTask implements Runnable {
+ private Task<?> latchTask;
+ private Entity unmanageEntity;
+
+ public UnmanageTask(Task<?> latchTask, Entity unmanageEntity) {
--- End diff --
mark `latchTask` as `@Nullable`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/482#issuecomment-72024065
good fixes; only minor comments then let's merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/482#discussion_r23766971
--- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynTaskTags.java ---
@@ -346,6 +347,26 @@ public static boolean isInEffectorTask(Task<?> task, @Nullable Entity entity, @N
return false;
}
+ @Beta
+ public static Task<?> getEffectorParentTask(Task<?> child, Effector<?> effector) {
--- End diff --
rename as `getClosestEffectorTask()` ? it's not necessarily the parent. `closest` is used in the jquery sense.
might be useful eventually to refactor to use predicates, but probably not yet...
and add a one-line javadoc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/482#issuecomment-72030374
@ahgittin Addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---