You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/26 20:08:29 UTC
(commons-logging) 01/03: Use Checkstyle ParenPad
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit 1a30b658bd45a06da4eb01271931decc9b7f2754
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 26 15:06:34 2023 -0500
Use Checkstyle ParenPad
---
checkstyle.xml | 16 ++++++++--------
.../commons/logging/impl/Jdk13LumberjackLogger.java | 21 ++++++++++-----------
2 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/checkstyle.xml b/checkstyle.xml
index 0b20a08..163b762 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -15,7 +15,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
-
<!DOCTYPE module PUBLIC
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">
@@ -23,7 +22,7 @@ limitations under the License.
<!-- commons logging customization of default Checkstyle behavior -->
<module name="Checker">
<property name="localeLanguage" value="en" />
- <property name="severity" value="warning"/>
+ <property name="severity" value="warning" />
<!-- Checks whether files end with a new line. -->
<!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
@@ -57,7 +56,7 @@ limitations under the License.
</module>
<module name="LineLength">
- <property name="max" value="160"/>
+ <property name="max" value="160" />
</module>
<module name="TreeWalker">
@@ -65,12 +64,13 @@ limitations under the License.
<property name="option" value="eol" />
</module>
<module name="ImportOrder">
- <property name="option" value="top"/>
- <property name="groups" value="java,javax,org"/>
- <property name="ordered" value="true"/>
- <property name="separated" value="true"/>
- <property name="sortStaticImportsAlphabetically" value="true"/>
+ <property name="option" value="top" />
+ <property name="groups" value="java,javax,org" />
+ <property name="ordered" value="true" />
+ <property name="separated" value="true" />
+ <property name="sortStaticImportsAlphabetically" value="true" />
</module>
<module name="WhitespaceAfter" />
+ <module name="ParenPad" />
</module>
</module>
diff --git a/src/main/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java b/src/main/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
index ce66e4b..19c9978 100644
--- a/src/main/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
+++ b/src/main/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
@@ -159,11 +159,10 @@ public class Jdk13LumberjackLogger implements Log, Serializable {
final Throwable throwable = new Throwable();
throwable.fillInStackTrace();
final StringWriter stringWriter = new StringWriter();
- final PrintWriter printWriter = new PrintWriter( stringWriter );
- throwable.printStackTrace( printWriter );
+ final PrintWriter printWriter = new PrintWriter(stringWriter);
+ throwable.printStackTrace(printWriter);
final String traceString = stringWriter.getBuffer().toString();
- final StringTokenizer tokenizer =
- new StringTokenizer( traceString, "\n" );
+ final StringTokenizer tokenizer = new StringTokenizer(traceString, "\n");
tokenizer.nextToken();
String line = tokenizer.nextToken();
while (!line.contains(this.getClass().getName())) {
@@ -172,13 +171,13 @@ public class Jdk13LumberjackLogger implements Log, Serializable {
while (line.contains(this.getClass().getName())) {
line = tokenizer.nextToken();
}
- final int start = line.indexOf( "at " ) + 3;
- final int end = line.indexOf( '(' );
- final String temp = line.substring( start, end );
- final int lastPeriod = temp.lastIndexOf( '.' );
- sourceClassName = temp.substring( 0, lastPeriod );
- sourceMethodName = temp.substring( lastPeriod + 1 );
- } catch ( final Exception ex ) {
+ final int start = line.indexOf("at ") + 3;
+ final int end = line.indexOf('(');
+ final String temp = line.substring(start, end);
+ final int lastPeriod = temp.lastIndexOf('.');
+ sourceClassName = temp.substring(0, lastPeriod);
+ sourceMethodName = temp.substring(lastPeriod + 1);
+ } catch (final Exception ex) {
// ignore - leave class and methodname unknown
}
classAndMethodFound = true;