You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/08 12:46:02 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
DaanHoogland opened a new pull request, #6237:
URL: https://github.com/apache/cloudstack/pull/6237
### Description
This PR fixes a sonar finding: https://sonarcloud.io/project/issues?issues=AYAI9l8k5Irk9_td-cXb&open=AYAI9l8k5Irk9_td-cXb&id=apachecloudstack
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1093993199
@rohityadavcloud , before we merge, how/where do we see the sonar score improve? ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1094949270
great, it shows as 'closed' now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1094693614
@DaanHoogland let me explore how we can setup per-PR sonar build/analysis runs. For now, you'll need to build and upload the quality stats (a jacoco xml or csv file). I can do that manually once the PR passes, alt you can create a dummy org for yourself and upload manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092829824
@DaanHoogland can you rebase and target it to the 4.16 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092935109
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1094899237
@DaanHoogland ran another build/run for the sonar/jacoco analysis, you can check the issue in say about an hour if it shows up as resolved on the dashboard. I'll setup a daily run on main branch in Jenkins (soon) so sonar gets updated, for per-PR integration it requires setting up a Github secret - which I'll explore if it's at all possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092894852
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092935713
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1093541472
<b>Trillian test result (tid-3848)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35855 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6237-t3848-vmware-67u3.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092894416
Thanks @DaanHoogland
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092894064
done @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1092932325
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #6237: potential null pointer in condition; AYAI9l8k5Irk9_td-cXb
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on PR #6237:
URL: https://github.com/apache/cloudstack/pull/6237#issuecomment-1094003415
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org