[jira] [Commented] (LUCENE-6022) DocValuesDocIdSet: check deleted docs before doc values

["Ryan Ernst (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181542#comment-14181542 ] 

Ryan Ernst commented on LUCENE-6022:
------------------------------------

+1, patch looks good. And I especially like the simplification to {{nextDoc()}} to just use {{advance(doc + 1)}}...we should do this in more places.

> DocValuesDocIdSet: check deleted docs before doc values
> -------------------------------------------------------
>
>                 Key: LUCENE-6022
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6022
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>             Fix For: 5.0
>
>         Attachments: LUCENE-6022.patch
>
>
> When live documents are not null, DocValuesDocIdSet checks if doc values match the document before the live docs. Given that checking if doc values match could involve a heavy computation (eg. geo distance) and that the default codec has live docs in memory but doc values on disk, I think it makes more sense to check live docs first?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org