You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2017/05/10 16:58:56 UTC

[trafficserver] branch master updated: Coverity CID #1374941 Logically dead code

This is an automated email from the ASF dual-hosted git repository.

sorber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  480ac7d   Coverity CID #1374941 Logically dead code
480ac7d is described below

commit 480ac7d831dd0af810ae5b5fce68dfd890481d65
Author: Phil Sorber <so...@apache.org>
AuthorDate: Wed May 10 09:53:36 2017 -0600

    Coverity CID #1374941 Logically dead code
---
 proxy/http/HttpTransactHeaders.cc | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/proxy/http/HttpTransactHeaders.cc b/proxy/http/HttpTransactHeaders.cc
index d4b0649..d3376e2 100644
--- a/proxy/http/HttpTransactHeaders.cc
+++ b/proxy/http/HttpTransactHeaders.cc
@@ -484,9 +484,9 @@ HttpTransactHeaders::downgrade_request(bool *origin_server_keep_alive, HTTPHdr *
 void
 HttpTransactHeaders::generate_and_set_squid_codes(HTTPHdr *header, char *via_string, HttpTransact::SquidLogInfo *squid_codes)
 {
-  SquidLogCode log_code;
-  SquidHierarchyCode hier_code;
-  SquidHitMissCode hit_miss_code;
+  SquidLogCode log_code          = SQUID_LOG_EMPTY;
+  SquidHierarchyCode hier_code   = SQUID_HIER_EMPTY;
+  SquidHitMissCode hit_miss_code = SQUID_HIT_RESERVED;
 
   /////////////////////////////
   // First the Hit-Miss Code //
@@ -614,9 +614,7 @@ HttpTransactHeaders::generate_and_set_squid_codes(HTTPHdr *header, char *via_str
     if (log_code == SQUID_LOG_TCP_MISS || log_code == SQUID_LOG_TCP_IMS_MISS) {
       log_code = SQUID_LOG_ERR_READ_TIMEOUT;
     }
-    if (hier_code == SQUID_HIER_SIBLING_HIT) {
-      hier_code = SQUID_HIER_TIMEOUT_SIBLING_HIT;
-    } else if (hier_code == SQUID_HIER_PARENT_HIT) {
+    if (hier_code == SQUID_HIER_PARENT_HIT) {
       hier_code = SQUID_HIER_TIMEOUT_PARENT_HIT;
     } else {
       hier_code = SQUID_HIER_TIMEOUT_DIRECT;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].