You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/05 22:19:57 UTC

[GitHub] [kafka] ijuma opened a new pull request #10272: MINOR: Various javadoc fixes

ijuma opened a new pull request #10272:
URL: https://github.com/apache/kafka/pull/10272


   - Use consistent options for `javadoc` and `aggregatedJavadoc`
   - `aggregatedJavadoc` depends on `compileJava`
   - `connect-api` inherits `options.links`
   - `streams` and `streams-test-utils` javadoc exclusions should be more
   specific to avoid unexpected behavior in `aggregatedJavadoc` where the
   javadoc for multiple modules is generated together
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10272: MINOR: Various javadoc fixes

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10272:
URL: https://github.com/apache/kafka/pull/10272#issuecomment-791986296


   You have to test with Java 8. I filed https://issues.apache.org/jira/browse/KAFKA-12435 for the Java 11 issue yesterday. It's not clear that there's an easy fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #10272: MINOR: Various javadoc fixes

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #10272:
URL: https://github.com/apache/kafka/pull/10272


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10272: MINOR: Various javadoc fixes

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10272:
URL: https://github.com/apache/kafka/pull/10272#issuecomment-793937511


   Merged to trunk and cherry-picked to 2.8 for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #10272: MINOR: Various javadoc fixes

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10272:
URL: https://github.com/apache/kafka/pull/10272#discussion_r589575603



##########
File path: build.gradle
##########
@@ -92,12 +92,6 @@ allprojects {
     }
   }
 
-  tasks.withType(Javadoc) {
-    // disable the crazy super-strict doclint tool in Java 8

Review comment:
       It seemed a bit redundant since we only support Java 8+. I can add back something.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on a change in pull request #10272: MINOR: Various javadoc fixes

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10272:
URL: https://github.com/apache/kafka/pull/10272#discussion_r588876527



##########
File path: build.gradle
##########
@@ -92,12 +92,6 @@ allprojects {
     }
   }
 
-  tasks.withType(Javadoc) {
-    // disable the crazy super-strict doclint tool in Java 8

Review comment:
       How about keeping those comments? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org