[jira] Commented: (GERONIMO-3741) Fail to install plugin via deploy.bat/sh

["Donald Woods (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557288#action_12557288 ] 

Donald Woods commented on GERONIMO-3741:
----------------------------------------

Quick review of this patch, I'm not sure how this solves anything....
If SourceRepositoryFactory.getSourceRepository() isn't handling being passed a NULL, then either defaultRepository should never be null and we need to fix the underlying cause of this (which seems like the proper fix to me) or have getSourceRepository() log a message and then return null if that is a valid value....


> Fail to install plugin via deploy.bat/sh
> ----------------------------------------
>
>                 Key: GERONIMO-3741
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3741
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.1
>            Reporter: YunFeng Ma
>             Fix For: 2.1
>
>         Attachments: GERONIMO-3741.patch
>
>
> Using deploy.bat/sh to install a plugin, get the following error:
> > deploy --user system --password manager install-plugin F:\apache\geronimo\plugins\debugviews\debugviews-jetty\target\debugviews-jetty-2.1-SNAPSHOT.car
> Using GERONIMO_BASE:   F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_HOME:   F:\apache\geronimo\testsuite\console-testsuite\target\geronimo-jetty6-javaee5-2.1-SNAPSHOT
> Using GERONIMO_TMPDIR: var\temp
> Using JRE_HOME:        C:\Program Files\IBM\Java50\jre
> 16:01:26,921 WARN  [AbstractGBeanReference] GBean references are not using proxi
> es
> Checking for status every 1000ms:
> Finished downloading
> org.apache.geronimo.plugins/debugviews-jetty/2.1-SNAPSHOT/car (358 kB) (100%)
> Installation FAILED: null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.