You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Pete Wyckoff (JIRA)" <ji...@apache.org> on 2008/09/08 09:30:44 UTC
[jira] Created: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
--------------------------------------------------------------------------------------------------------------
Key: HADOOP-4113
URL: https://issues.apache.org/jira/browse/HADOOP-4113
Project: Hadoop Core
Issue Type: Improvement
Components: libhdfs
Reporter: Pete Wyckoff
Priority: Minor
Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4113:
---------------------------------
Assignee: Pete Wyckoff
Status: Patch Available (was: Open)
This patch addresses Owen's concerns about commenting out the exits where they should have just been deleted.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630188#action_12630188 ]
Hudson commented on HADOOP-4113:
--------------------------------
Integrated in Hadoop-trunk #600 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/600/])
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4113:
---------------------------------
Attachment: patch0.txt
note - ant -Dlibhdfs=1 test-libhdfs passed
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629219#action_12629219 ]
Pete Wyckoff commented on HADOOP-4113:
--------------------------------------
Not new tests because Like 3963, this patch is for very abhorrent behavior, so the libhdfd testing infra cannot test this, but the current tests cover this patch other than when something happens like the classpath is bad and the whole thing would fail anyway.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629295#action_12629295 ]
Pete Wyckoff commented on HADOOP-4113:
--------------------------------------
Looking at the code, I see this still didn't fix all the places where exit was commented out instead of removed. Will have to submit a new patch.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629194#action_12629194 ]
Hadoop QA commented on HADOOP-4113:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389659/patch0.txt
against trunk revision 693048.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3207/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3207/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3207/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3207/console
This message is automatically generated.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629308#action_12629308 ]
Zheng Shao commented on HADOOP-4113:
------------------------------------
+1
Reviewed the difference between patch0.txt and HADOOP-4113.1.txt. It looks good.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4113:
---------------------------------
Status: Patch Available (was: Open)
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4113:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Pete!
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4113:
---------------------------------
Attachment: HADOOP-4113.1.txt
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4113) libhdfs should never exit on its own
but rather return errors to the calling application - missing diff files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-4113:
---------------------------------
Status: Open (was: Patch Available)
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Priority: Minor
> Attachments: patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629341#action_12629341 ]
Hadoop QA commented on HADOOP-4113:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389701/HADOOP-4113.1.txt
against trunk revision 693048.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3211/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3211/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3211/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3211/console
This message is automatically generated.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4113) libhdfs should never exit on its
own but rather return errors to the calling application - missing diff
files
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629343#action_12629343 ]
Pete Wyckoff commented on HADOOP-4113:
--------------------------------------
it's ready -
re -1 on tests included: there is currently no way to add tests which do things like include a bad classpath in the libhdfs tests, so forcing an exit is basically impossible.
> libhdfs should never exit on its own but rather return errors to the calling application - missing diff files
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4113
> URL: https://issues.apache.org/jira/browse/HADOOP-4113
> Project: Hadoop Core
> Issue Type: Improvement
> Components: libhdfs
> Reporter: Pete Wyckoff
> Assignee: Pete Wyckoff
> Priority: Minor
> Attachments: HADOOP-4113.1.txt, patch0.txt
>
>
> Hadoop-3963 second patch did not include the small changes to hdfsJniHelper.c. sorry.
> this definitely concludes removing exits from libhdfs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.